#
✕ nick:jannau
#asahi-dev · 2023-01-24 13:46
jannauI think dcp lowers the brightness and not macOS. otherwise it would not safe to enble
#asahi-dev · 2023-01-24 13:45
jannausafe in the sense it will not destroy the backlight immediately
#asahi-dev · 2023-01-24 13:44
jannauthe HDR display seems not to be designed in California. the m2 pro/max specs say the max brightness works only up to 25°C
#asahi-dev · 2023-01-24 13:41
jannauit's probably not totally unsafe since I think dcp has direct access to the display temp sensors
#asahi-dev · 2023-01-24 13:40
jannauI haven't looked into it but I've seen macos setting more bools in the field I identified as enable flag
#asahi-dev · 2023-01-24 13:38
jannaurowanG337: that is certainly not a priority for us but I guess it will become obvious how to do that once we support HDR itself
#asahi-dev · 2023-01-24 11:28
jannauthe installer needs needs to adapted for new machines. we need 13.2 support, wifi/bt FW extraction for the new machines and fixed m1n1 and kernel with devicetrees for the new machines
#asahi-dev · 2023-01-24 11:22
jannauif we're unlucky we have to do the dp-altmode setup with the dptx EP
#asahi-dev · 2023-01-24 11:21
jannauyes, at least broken dart stream ID for dcp. maybe vm-base and potentially we have init the display crossbar and the dp2hdmi converter
#asahi-dev · 2023-01-24 11:18
jannauRy_Darcy: a couple of days maybe, first we need make everything works. display is currently completely broken
#asahi-dev · 2023-01-24 10:44
jannaucounts: 5
#asahi-dev · 2023-01-24 10:22
jannauyes. build is 22A8380 compared to 22A380 of the public 13.0 release
#asahi-dev · 2023-01-24 09:36
jannauthe m2 mac mini comes with macOS 13.0
#asahi-dev · 2023-01-24 08:21
jannauI would have assumed thunderbolt depends on that
#asahi-dev · 2023-01-23 18:45
jannausame build as the release candidate
#asahi-dev · 2023-01-23 07:47
jannauoh, I still have "APPLE_RTKIT_PWR_STATE_INIT = 0x220" for dcp. WAKEUP or RESUME might be a better name with 0x201 named IDLE
#asahi-dev · 2023-01-23 06:58
jannauthere is a second array of IOSurfaces* but otherwise just standard type pointers
#asahi-dev · 2023-01-23 06:47
jannaumight be just for tiling on higher resolutions but could also for MST support
#asahi-dev · 2023-01-23 06:46
jannauI don't need that to get dcp to work with 13.2. this is more curiosity about the use case
#asahi-dev · 2023-01-23 06:43
jannauah, easier than I thought
#asahi-dev · 2023-01-23 06:42
jannaubut it doubles the amount of nullable pointers
#asahi-dev · 2023-01-23 06:42
jannauit doesn't quite fit with the increase in swaprec/iosurface size changes
#asahi-dev · 2023-01-23 06:41
jannauthe change for swap_submit_dcp feels like apple added a second swaprec and set of 4 surfaces
#asahi-dev · 2023-01-23 06:39
jannaudid you get the the function signatures in trace_dcp.py automatically from binary analysis?
#asahi-dev · 2023-01-23 06:38
jannauyes, you did
#asahi-dev · 2023-01-23 06:37
jannaumarcan: I'm not sure I even need the devm_apple_rtkit_free() or do you mean your apple_rtkit_idle() as well?
#asahi-dev · 2023-01-22 18:57
jannaudoes the dongle work reliably when connected to other devices
#asahi-dev · 2023-01-22 16:40
jannaunot really happy with the backlight handling. I wish the drm backlight integration would progress faster
#asahi-dev · 2023-01-22 16:39
jannauok, missing swap or modeset sounds reasonable and it appears it's called then the backlight devices reappears
#asahi-dev · 2023-01-22 16:36
jannauthe backlight device gets only registered after dcp is (re)started and reports the current brightness
#asahi-dev · 2023-01-22 16:08
jannau+1
#asahi-dev · 2023-01-22 16:07
jannauI think the wait_ready change is not that important. it prevents a "drm: crtc missing modes" during fbdev initailization
#asahi-dev · 2023-01-22 16:05
jannaumarcan: component (linux/component.h) based probing starts when the last missing component is probed
#asahi-dev · 2023-01-22 16:03
jannaudriver changes will be a little annoying. firmware specific call/callback tables and structures
#asahi-dev · 2023-01-22 16:02
jannauI'm currently working on updating trace_dcp.py for 13.2
#asahi-dev · 2023-01-22 16:01
jannauthe deferred probe / gdm startup race should be fixed now
#asahi-dev · 2023-01-22 15:59
jannaulooks ok. nice though that the reset recovered from this. I still consider the module reload and reset handling as unsupported
#asahi-dev · 2023-01-22 15:49
jannauI see it here with a timeout for setDCPPower() and there's a syslog message after that
#asahi-dev · 2023-01-22 15:45
jannaumarcan: reproduced with "soc: apple: apple-pmgr-pwrstate: Switch to IRQ-safe mode" reverted
#asahi-dev · 2023-01-22 15:24
jannauI see neither on t8103-j274 without always-on for ps_disp0_cpu0. testing now with always-on
#asahi-dev · 2023-01-22 15:15
jannaubut I could have missed resets there
#asahi-dev · 2023-01-22 15:15
jannaubut I think I was mostly testing on t8103 without always-on added that only for the PR, it was always there for t600x and t8112 though
#asahi-dev · 2023-01-22 15:13
jannaualways-on should not matter, dcp removes that on probe
#asahi-dev · 2023-01-22 15:12
jannausoc: apple: apple-pmgr-pwrstate: Switch to IRQ-safe mode is missing
#asahi-dev · 2023-01-22 15:03
jannaustill unexpected. should only trigger after module unloading
#asahi-dev · 2023-01-22 15:03
jannauon the initial probe? no, that's unexpected
#asahi-dev · 2023-01-22 14:37
jannaua0139ccbde88 can be dropped from bits/200-dcp wrong branch and change is already squashed in bits/020-t6000-dart
#asahi-dev · 2023-01-22 14:35
jannaudepends on https://github.com/AsahiLinux/m1n1/pull/272 and https://github.com/AsahiLinux/linux/pull/105
#asahi-dev · 2023-01-22 14:34
jannaumarcan: https://github.com/jannau/linux/tree/dcp_runtime_pm based on asahi-6.2-rc3-5 I hope you don't mind sorting the patches into their bits/* branches. creating PRs for all of them is a little tedious
#asahi-dev · 2023-01-22 14:13
jannaumarcan: ok, I'll prepare it. not sure if I want to something about the PCIe dart runtime PM hack

plus ›