#
✕ nick:jannau
#asahi-dev · 2024-05-12 21:00
jannaubut hw as apples which has mostly universal planes it doesn't make much of difference
#asahi-dev · 2024-05-12 20:59
jannauHW / drivers can have "arbitrary" restrictions on planes so it makes sense that hardware which has real HW cursor support to export that as cursor plane
#asahi-dev · 2024-05-12 20:57
jannaufor userspace it's just a hint
#asahi-dev · 2024-05-12 20:56
jannauthe kernel needs a cursor plane to emulate the old cursor ioctls
#asahi-dev · 2024-05-12 20:56
jannauthe type enumerations are for backward compatibility in the kernel
#asahi-dev · 2024-05-12 13:22
jannauthe plane types are not going away but it would be reasonable for universal planbe aware user space client to fallback using an overlay plane for HW cursor
#asahi-dev · 2024-05-12 12:12
jannauthe issue with with surface 0 is that x2rgb10 wasn't respectinmg the color space and was always using apple's wide rgb space
#asahi-dev · 2024-05-12 12:04
jannauchadmed: the squishing at the edges is dcp's doing. it requires that 32x32 of the cursor plane are on the screen. This is the reason why there is no HW cursor support
#asahi-dev · 2024-05-12 09:59
jannauwhich apparently takes around 0.7 ms longer from swap_submit ot swap_complete
#asahi-dev · 2024-05-12 09:59
jannaufixes the the half rate display on on devices where dcpext is used
#asahi-dev · 2024-05-12 09:58
jannaupushed out asahi-6.8.9-5 with this bt le fix and some "fixups" for the flip complete timestamps so that kwin commits in time
#asahi-dev · 2024-05-12 09:55
jannausven: I've switched to b4 (https://b4.docs.kernel.org/en/latest/) and that beats manual git format-patch/send-email use by heaps and bounds. especially for cover letter composing and revisions
#asahi-dev · 2024-05-12 09:45
jannausven: typo "Broadcpm" in include/net/bluetooth/hci.h
#asahi-dev · 2024-05-12 09:43
jannauyes, schould be only bcm4387. I have a fixup commit for our out of tree bcm4388 support
#asahi-dev · 2024-05-12 09:41
jannaushouldn't the fixes tag be Fixes: 2e7ed5f5e69b ("Bluetooth: hci_sync: Use advertised PHYs on hci_le_ext_create_conn_sync")? also please add "Cc: stable@vger.kernel.org"
#asahi-dev · 2024-05-12 09:38
jannausven: feel free to add my Tested-by:
#asahi-dev · 2024-05-12 09:37
jannauI think it's not necessary on bcm4378, at least bt le still worked on j274
#asahi-dev · 2024-05-12 09:35
jannausven: works, I confused myself for a moment by the missing bcm4388 support upstream
#asahi-dev · 2024-05-12 08:51
jannauI always forget if I already checked if the comment matches the code. looks to me like it might be checking for 4x downscaling and 2x upscaling
#asahi-dev · 2024-05-12 08:50
jannauI don't think dcp is complaining about what apple_plane_atomic_check is checking
#asahi-dev · 2024-05-12 08:47
jannauthis has nothing to do with scaling on DRM/KMS level. dcp interprets sizes smaller than 32 as requests for scaling
#asahi-dev · 2024-05-12 07:36
jannauapparently page flips are slower on dcpext compared to dcp, no or less issues on m1 mac mini
#asahi-dev · 2024-05-12 07:23
jannaumin_width/height are checked in addfb2 but we might need to check the plane's CRTC_W/CRTC_H
#asahi-dev · 2024-05-12 07:08
jannauchadmed: reject it in apple_plane_atomic_check() then
#asahi-dev · 2024-05-12 05:58
jannaunicolas17: macos uses hw cursors but switches to sw cursors when the cursor hits the screen edges
#asahi-dev · 2024-05-12 05:57
jannauthe default cursor size is 64x64, I would expect drm helpers already check / enforce mode_config.min_width / mode_config.min_height
#asahi-dev · 2024-05-11 09:57
jannaufalling back to an overlay plane if no cursor plane is provided would be reasonably
#asahi-dev · 2024-05-11 09:56
jannau"For userspace which is universal plane aware and which is using that atomic IOCTL there’s no difference between these planes"
#asahi-dev · 2024-05-11 09:56
jannauhttps://www.kernel.org/doc/html/latest/gpu/drm-kms.html?highlight=drm_plane_type_overlay#c.drm_plane_type
#asahi-dev · 2024-05-11 09:56
jannauuser space applications could, the kernel documentation doesn't require anything
#asahi-dev · 2024-05-11 09:23
jannauhow are your X pixels initialized when using XBGG or XRGB? if they are set to 0 of course it will work
#asahi-dev · 2024-05-11 09:19
jannauare you referring to "DCP doesn't support XBGR8 / XRGB8 natively."
#asahi-dev · 2024-05-11 09:17
jannauI don't understand what your referring to. you can't enable overlays because it certainly will break HW cursors with some compositors
#asahi-dev · 2024-05-11 07:24
jannaubut that means that the patches will be rebased on each v6.x.y release and change commit ids but not contents
#asahi-dev · 2024-05-11 07:23
jannauI'm unsure which is the better model. since stable patches can introduce regressions (see bt in v6.8.9) I see use in rebasing on stable releases
#asahi-dev · 2024-05-11 07:20
jannaujohn-cabaj: I started doing rebases onto linux stable releases. For two reasons, 1. the wifi branch conflicted non-trivially with 6.8.4 2. some distro's are consuming the tags as is, i.e. don't get any linux stable fixes themself
#asahi-dev · 2024-05-09 10:24
jannaumarcan identified a possible explanation for it in #asahi-fedora-dev
#asahi-dev · 2024-05-09 10:04
jannau`curl -6 -v -LO https://chadmed.au/res/kwin.syscap` works for me, startup seems a little slow but it finishes in a reasonable amount of time overall
#asahi-dev · 2024-05-08 20:41
jannaunicolas17: https://mastodon.social/@bshanks/112401605018159567
#asahi-dev · 2024-05-08 19:56
jannau"enhanced, next-generation ML accelerators" seems to be indeed SME/SVE2
#asahi-dev · 2024-05-08 05:54
jannauof course they will, early point releases usually still have dcp firmware API changes
#asahi-dev · 2024-05-08 05:46
jannaudisplay changes are hopefully mostly abstracted away by the firmware interface. the changes could be necessary because each panel is driven separately
#asahi-dev · 2024-05-07 14:46
jannauI hope "enhanced, next-generation ML accelerators" for the CPU cores is SME/SVE2
#asahi-dev · 2024-05-07 14:46
jannaucpu cores, neural engine and dcp might be updated
#asahi-dev · 2024-05-07 14:37
jannauhttps://www.apple.com/newsroom/2024/05/apple-introduces-m4-chip/
#asahi-dev · 2024-05-07 14:19
jannausigh, m4
#asahi-dev · 2024-05-06 06:56
jannauI would assume it does. I suppose someone has to sit in front of a TV / AV amplifier and trace what macos/dcp does
#asahi-dev · 2024-05-06 06:42
jannaubitstream format would be pointless if they need to decoded first. DCP has no audio encoders (I hope)
#asahi-dev · 2024-05-06 06:38
jannauI think bitstream formats are simply not yet looked at. I think povik tested only with monitor(s) which support only stereo pcm
#asahi-dev · 2024-05-06 06:33
jannauchadmed: it didn't looked like a good fit. we query channel maps / rates from dcp. we only support PCM. I'm sure povik looked at hdmi-codec and decided against using it (initially)

plus ›