#asahi-dev · 2025-12-24 13:06
jannaudcp_surface is at least for now mostly unversioned and it allows moving code from templated code#asahi-dev · 2025-12-24 13:05
jannauchadmed: I was thinking about something like https://github.com/jannau/linux/commit/85a8222c8d92338416fe685f3274101132752e57 (untested since I don't want to unpack a test macbook on the train)#asahi-dev · 2025-12-23 18:12
jannauchadmed: the annoying part of dcp_surface is that it's firmware version dependent#asahi-dev · 2025-12-23 18:11
jannausofus: no they use SPI to transport the HID packets but the HID interface should be the same or very similar#asahi-dev · 2025-12-23 15:37
jannauit started this was because there was only a single plane anyway#asahi-dev · 2025-12-23 15:36
jannauchadmed: we should create our own plane struct, embed drm_plane and dcp_surface and fill the dcp surface in apple_plane_atomic_update()#asahi-dev · 2025-12-23 13:25
jannauchadmed: how does it look exactly? the compression metadata is in a separate chunkt of the buffer? do we need per tile information without compression?#asahi-dev · 2025-12-23 13:22
jannausofus: great. I believe the HID interface on M1* machines is similar but hid transport might miss some things#asahi-dev · 2025-12-23 13:20
jannauwhat do we need to pass on as metadata?#asahi-dev · 2025-12-23 13:20
jannauyou could look at dcp's tracing#asahi-dev · 2025-12-23 13:19
jannauif you miss vblank it waits until the next one which is is usually more than 5s#asahi-dev · 2025-12-23 11:48
jannauthis is required because every compositor has its on guess on when exactly before the page flip it needs to commit the update. There are talks of adding a hint to the KMS interface so that the driver can communicate its guess#asahi-dev · 2025-12-23 11:37
jannauDRM_CAP_ATOMIC_ASYNC_PAGE_FLIP might help (especially with cursor updates) but implementing it could be hard and require further dcp RE#asahi-dev · 2025-12-23 11:36
jannauthat's not how atomic commits work and shouldn't matter as compositors base their timing on the page flip event and not on when their commit returns#asahi-dev · 2025-12-23 11:22
jannauI haven't seen that but I only tested briefly with firefox/testufo. kwin was fine but cosmic-comp didn't get 120Hz. we might need to adjust the hacky page flip time hackery#asahi-dev · 2025-12-23 08:21
jannauunrelated to the color space set for the surface. if the CTM applies post blending and dcp uses a differrent colorspace post blending it might not have the desired effect (but should not cause a green tint in any case)#asahi-dev · 2025-12-23 08:10
jannauI don't test it often and have it disabled but in tests it always made the screen orange/red with higher color temperatures. I'm just not sure if it it the right amount since I'm unsure when and in which color space the ctm is applied#asahi-dev · 2025-12-23 07:49
jannauno. why would anyone turn that on if accurate colors are desired. I wanted to test if ctm has the intended effect but never did#asahi-dev · 2025-12-23 06:52
jannauthe mbp 14-inch display wasn't far off when I measured it (2023 / 2024) assuming I did not screw up the measurement and interpreted the results correctly#asahi-dev · 2025-12-22 23:00
jannauI have one#asahi-dev · 2025-12-22 21:07
jannauI haven't looked into how the higher brightness for HDR is handled except that's likely not in the same way as we handle the backlight currently#asahi-dev · 2025-12-22 21:05
jannauoliver: we have information about the supported colorspaces. might be either somewhere in m1n1's dcp python code or I have notes#asahi-dev · 2025-12-22 13:01
jannauah. you could try waylandsink full screen or with enabled overlays in kwin#asahi-dev · 2025-12-22 12:27
jannauwhy would it tear at all unless gstreamer writes to currently scanned-out surfaces#asahi-dev · 2025-12-22 08:47
jannauNULL ptr deref in DCP's afk code in asahi-wip/6.18. not sure what could have changed there#asahi-dev · 2025-12-22 08:39
jannauchadmed: it might have been renumbered#asahi-dev · 2025-12-21 22:39
jannauI think there are multiple interpretations possible. there's probably not much difference in practice but it's still worth experimenting to see if we can learn more#asahi-dev · 2025-12-21 22:33
jannauthe HV isn't stealing time anymore by default (by modifying various timers)#asahi-dev · 2025-12-21 22:26
jannauoliver: with the relative timeing I tought that maybe dcp interprets one of the timestamps as current time. the other timestamps would then be relative to that one#asahi-dev · 2025-12-21 19:55
jannauI think we're speaking past each other#asahi-dev · 2025-12-21 19:45
jannauI mean relative to one of the ts fields. i.e. ts_X is the current time and the other fields are relative to it#asahi-dev · 2025-12-21 19:38
jannaubut I wouldn't rule out that the timestamps are all relative. that would explain why setting a static value works#asahi-dev · 2025-12-21 19:37
jannauoliver: I wouldn't necessarily trust timestamps vs real time relations from traces#asahi-dev · 2025-12-21 19:30
jannaumacbook pro hdmi out fixed#asahi-dev · 2025-12-21 15:15
jannauI've tagged and pushed u-boot asahi-v2025.10-1#asahi-dev · 2025-12-21 13:38
jannauI'll first look into u-boot and afterwards into the hdmi out#asahi-dev · 2025-12-21 13:34
jannaunot yet tagged because the usb changes are expected to break usb in u-boot and the macbook pro HDMI output is very likely broken as well#asahi-dev · 2025-12-21 13:32
jannauI've pushed a v6.18.2 based tree to asahi-wip (untagged). Most signifant changes: upstream(-ish) dwc3/atc USB support and asahi GPU driver updates in preparation for upstreaming#asahi-dev · 2025-12-21 13:16
jannaushould not make much of a difference in practice#asahi-dev · 2025-12-21 13:15
jannauinstead of submit and present time I could imagine present time and timeout#asahi-dev · 2025-12-21 13:13
jannauI suspect last_present_time might be render start time (i.e. just informative)#asahi-dev · 2025-12-21 13:09
jannauoliver: I pulled the PR and modified it as suggested#asahi-dev · 2025-12-21 13:08
jannauI think I want to have a better understanding what the timestamps mean before setting them for all displays#asahi-dev · 2025-12-20 16:47
jannaumerged. I guess we don't really call proxy.free() that often#asahi-dev · 2025-12-20 12:21
jannauah#asahi-dev · 2025-12-20 12:20
jannauI don't remember if main_display might be true for the HDMI port of M1 desktop devices#asahi-dev · 2025-12-20 12:19
jannauyou still have to limit it to 14-/16-inch macbook pros, doesn't matter much anyway#asahi-dev · 2025-12-20 12:18
jannauthis is going to change soon anyway since I plan to split apple_connector#asahi-dev · 2025-12-20 12:17
jannauoliver_: I think the resolution of the internal displays is unique enough#asahi-dev · 2025-12-18 22:09
jannauyou can if you're interested in finding the the sense behind the timestamps and/or VRR. I've asked mostly out of curiosity at this point