#
✕ nick:j_ey
#asahi-dev · 2021-11-28 15:14
j_eyyeah
#asahi-dev · 2021-11-28 15:11
j_eyI think I can just ignore it, since Im keeping track of when the transfer is going to be cmplete anyway
#asahi-dev · 2021-11-28 15:08
j_ey*because I disable the interrupts after I know the transfer is complete
#asahi-dev · 2021-11-28 15:08
j_eythere is this bit REG_STATUS_COMPL.. but I think because I disable the interrurpts.. it seems to be set at the start of every new transfer
#asahi-dev · 2021-11-28 15:04
j_eyso yes, ive had a 30min video primer on SPI, I have no idea what Im doing :-)
#asahi-dev · 2021-11-28 15:03
j_eythis seems to match up what I learnt about SPI from watching one Ben Eater video about it lol
#asahi-dev · 2021-11-28 15:00
j_eythe packets from the keyboard/touchpad are 256 bytes, so we know theyre never going to be sent in one go..
#asahi-dev · 2021-11-28 15:00
j_eyI also wonder if I should remove that 'early return' https://gitlab.arm.com/linux-arm/jg-open/-/commit/799eac917c9dc1b358641725238a634245b21250#64e032c3d47a1edda1e3ae6be8b8f1d1be4464b6_0_139
#asahi-dev · 2021-11-28 14:57
j_eyI see what you mean now
#asahi-dev · 2021-11-28 14:57
j_eyhm
#asahi-dev · 2021-11-28 14:55
j_eyright, but this fills the FIFO for rx and tx, i assume the controller then takes data from the FIFO and does the right thing
#asahi-dev · 2021-11-28 14:54
j_eyI think those can go in either order? maybe not even have to be there at all!
#asahi-dev · 2021-11-28 14:54
j_eyif you mean the calls inside apple_spimc_transfer_one to apple_spimc_drain_rx and apple_spimc_fill_tx
#asahi-dev · 2021-11-28 14:52
j_eyneed bindings and runtime-pm, and I guess I can send it out..
#asahi-dev · 2021-11-28 14:49
j_eyI had some IRQ_NONE stuff in a previous revision, will try bring it back
#asahi-dev · 2021-11-28 14:45
j_eysven: thanks, I had a local TODO for that, just didnt get round to it
#asahi-dev · 2021-11-28 14:44
j_eyI found that I don't even need to set: config |= REG_CONFIG_IE_RXRDY;, seems to work fine without it
#asahi-dev · 2021-11-28 14:44
j_ey(but i assumed it was an ack, so left it in)
#asahi-dev · 2021-11-28 14:43
j_eythe status thing is cargo culted from corellium, will add it to the list of things to check
#asahi-dev · 2021-11-28 14:42
j_eysven: it's stopped here https://gitlab.arm.com/linux-arm/jg-open/-/commit/799eac917c9dc1b358641725238a634245b21250#64e032c3d47a1edda1e3ae6be8b8f1d1be4464b6_0_98
#asahi-dev · 2021-11-28 13:26
j_eyjannau: would be nice if you could try it out at some point. I seem to still get data from the tracpkad even after pressing capslock. (I dont have x11 or anything, but I put a pr_err in applespi_got_data and im at least getting prints when using the tracpkad)
#asahi-dev · 2021-11-28 13:23
j_eyso I put a branch here with my new SPI driver, if anyone is using the keyboard patches and wants to test it out https://gitlab.arm.com/linux-arm/jg-open/-/commits/spi/dev/
#asahi-dev · 2021-11-23 17:54
j_eysven: apple_rtkit_management_rx_epmap, why are bitmap and base inside that for loop?
#asahi-dev · 2021-11-23 16:15
j_ey0c503762d5d353945c0e16bcf14dbd8ffdf9e1e4
#asahi-dev · 2021-11-23 16:15
j_eymarcan: first commit has conflict markers
#asahi-dev · 2021-11-23 15:15
j_eyyeah https://support.apple.com/en-gb/guide/mdm/mdm580cf25bc/web
#asahi-dev · 2021-11-21 22:42
j_eymarcan: I thought you woke up early.. lol
#asahi-dev · 2021-11-21 22:32
j_ey(m1n1 supports irc proxy now, cool!)
#asahi-dev · 2021-11-20 10:57
j_eysven: might be nice as a first approach if it removes enough code?
#asahi-dev · 2021-11-13 17:16
j_eyjeffmiw: similar for the darts and pinctrl, they seem to have larger registers in the ADT than needed
#asahi-dev · 2021-11-12 19:34
j_eyI thought the same thing for SPI
#asahi-dev · 2021-11-11 09:40
j_eyerr, them, not me
#asahi-dev · 2021-11-11 09:40
j_eygive me a patch to keep out of tree? :)
#asahi-dev · 2021-11-11 09:32
j_eyO_O what broke it
#asahi-dev · 2021-11-10 20:58
j_eyoh, so if you want to run macos, then you might need a full install
#asahi-dev · 2021-11-10 20:57
j_eydunno!
#asahi-dev · 2021-11-10 20:57
j_eyi think uh..
#asahi-dev · 2021-11-10 20:53
j_eypovik: yes, just downloads the fw
#asahi-dev · 2021-11-10 20:47
j_eywhy not use the asahi installer? :P
#asahi-dev · 2021-11-10 19:42
j_eythat means its software fixable at least.. if not by "us"
#asahi-dev · 2021-11-10 18:55
j_eyRetr0id: i also have a non-working usbc monitor :<
#asahi-dev · 2021-11-10 10:30
j_eysven: kettenis true
#asahi-dev · 2021-11-10 10:28
j_eykettenis: we're likely to mirror the DTs in the linux repo anyway?
#asahi-dev · 2021-11-10 10:26
j_eysven: and also you need to turn disable some of the pcie stuff that's in the j274 dts otherwise it crashes on boot on the mba
#asahi-dev · 2021-11-10 10:25
j_eysven: i wanted to get a j313/mba dt in, since m1n1 is checking compatible now
#asahi-dev · 2021-11-10 10:18
j_eyfair, just wondering, it can wait!
#asahi-dev · 2021-11-10 10:15
j_eyarnd: can m1 mba dt come in after rc1? or does it need to wait for 5.17
#asahi-dev · 2021-11-09 11:40
j_eyyeah https://gitlab.arm.com/linux-arm/jg-open/-/commit/4e5f9ce10c901cb2a9f5cb79782773f67c6e0c29#43c6427788452164e3a6724d3a37d4aaad3a7b9c_124_139
#asahi-dev · 2021-11-09 11:18
j_eysven: how do other drivers like hwmon or whatever interact with the smc though?
#asahi-dev · 2021-11-09 11:13
j_eyyeah, that's something I don't really understand

plus ›