#asahi-dev · 2025-08-16 00:15
chadmeds/and,/,/ #asahi-dev · 2025-08-16 00:14
chadmedsven: so is the strat here to base the hwmon and rtc patches on 6.17 and, ignore the missing SMC dt nodes, and just note that we will take the dts patches ourselves once theyre reviewed?#asahi-dev · 2025-08-15 21:06
chadmedsven: yeah no stress#asahi-dev · 2025-08-15 14:15
chadmedi fixed the other one by simply deleting it :P #asahi-dev · 2025-08-15 12:08
chadmedokay all cleaned up #asahi-dev · 2025-08-15 11:40
chadmedwhat ive done here ensures that we will never cut a m1n1 release with buggy ffi btw, ive just kept it in the "intermediate" commits for storytelling and to not break rebases/bisects#asahi-dev · 2025-08-15 11:40
chadmedive only found load-bearing UB in two functions so far, one of which can be fixed by just factoring out some code. let me finish the git surgery and you can review the MR and see if you'd prefer to fix the C side versus what ive done here#asahi-dev · 2025-08-15 11:25
chadmedholy shit fixing that actually made things noticeably faster too #asahi-dev · 2025-08-15 11:11
chadmedmakes bisecting a hell of a lot easier#asahi-dev · 2025-08-15 11:11
chadmedi could just do the classic enterprise b2b saas `git commit -m "fixes"` strat but i think its nice when every commit actually builds and works#asahi-dev · 2025-08-15 11:10
chadmedi need to recreate the UB in the FFI binding intially, then once i fix the caller relying on that UB refactor the callee and then fix the original binding to use the sound version#asahi-dev · 2025-08-15 11:10
chadmedits okay i can fix it, its just a messy commit history #asahi-dev · 2025-08-15 10:32
chadmedadt_first_child_offset has load bearing UB in that if you return an error when the currently-scoped node does not have any children it will crash, so somewhere on the C side relies on it miscalculating the next node in memory as a "child" of the current node even if it is a sibling or completely unrelated#asahi-dev · 2025-08-15 10:30
chadmedsmdh im trying to make the public adt api more sound and im finding soooo much load-bearing UB on the C side#asahi-dev · 2025-08-13 02:18
chadmedso hopefully that goes away once all that is gone#asahi-dev · 2025-08-13 02:17
chadmedm1n1 stage 2 feels a couple hundred ms slower to load with the rust changes but i feel like thats all due to having to relocate pointers every time C asks for an ADT offset #asahi-dev · 2025-08-12 08:51
chadmedokay i think my idea to remove offsets from the rust side API might work#asahi-dev · 2025-08-11 11:14
chadmedthe runtime cost should be negligible though #asahi-dev · 2025-08-11 11:13
chadmedokay i have an idea for getting rid of offsets entirely but it will require some glue code for the C binding#asahi-dev · 2025-08-11 09:27
chadmedbut then we're doing that twice, since we still need to do that to get the reference to the node in the first place...#asahi-dev · 2025-08-11 09:26
chadmedi wonder then if its better to simply do get_reg(ADTNode *node, int reg_index) then internally build the tree and not expose path_offset_trace at all #asahi-dev · 2025-08-11 08:58
chadmedtook saas/cloud like 15 years to get to the same point :P #asahi-dev · 2025-08-11 08:57
chadmedwe're out of the blitzscaling phase and into the "haha whatre you gonna do, not use it?" phase #asahi-dev · 2025-08-11 08:55
chadmedi tried gpt-5 at work the other day out of curiosity and its honestly worse than i expected it to be #asahi-dev · 2025-08-11 08:54
chadmedi dont feel like rewriting like 30% of m1n1 before i go on holiday though#asahi-dev · 2025-08-11 08:53
chadmedyeah#asahi-dev · 2025-08-11 08:52
chadmedor we return AdtError::BadLength#asahi-dev · 2025-08-11 08:52
chadmednah they have to be the same size#asahi-dev · 2025-08-11 08:51
chadmedit cant add/remove nodes or properties#asahi-dev · 2025-08-11 08:50
chadmedchaos_princess: the API is incapable of making any changes though apart from setting the value of some property#asahi-dev · 2025-08-11 08:49
chadmedimo it should just be get_reg(*ADTNode node, int reg_index) #asahi-dev · 2025-08-11 08:48
chadmedthats why i didnt touch it and just copied it 1:1#asahi-dev · 2025-08-11 08:48
chadmedim not sure why get_reg needs to iterate over an entire absolute path though#asahi-dev · 2025-08-11 08:48
chadmedyeah the idea was to copy what fdt does but its not very ergonomic#asahi-dev · 2025-08-11 08:42
chadmedwhat do you consider awkward about it? i personally think the way you get a reg container is a bit insane but idk if thats constrained by how the ADT works or what#asahi-dev · 2025-08-11 08:31
chadmedthere are soooo many consumers #asahi-dev · 2025-08-11 08:31
chadmeddo we have coccinelle? :P#asahi-dev · 2025-08-11 06:49
chadmedgetting rid of them will allow the Rust side to be more sound by default#asahi-dev · 2025-08-11 06:48
chadmedthoughts on dropping unused parts of the ADT API? the original design was meant to be 1:1 with libfdt readonly but there are a few methods that are actually unused anywhere in m1n1 #asahi-dev · 2025-08-09 10:26
chadmedits already a much nicer API to use from within rust though so its a win #asahi-dev · 2025-08-09 10:25
chadmedso ill deal with that tomorrow#asahi-dev · 2025-08-09 10:25
chadmedno longer works#asahi-dev · 2025-08-09 10:25
chadmedive mostly refactored the adt rust MR but it uhhhh #asahi-dev · 2025-08-08 11:08
chadmedwe can discuss tomorrow but i reckon just get rid of it. it's not helpful at all #asahi-dev · 2025-08-08 08:25
chadmed500 mW error is too high when we're dealing with this signal level#asahi-dev · 2025-08-08 08:25
chadmedthat cpu measurement is kinda sus #asahi-dev · 2025-08-04 13:54
chadmedfedoras being ddosed#asahi-dev · 2025-08-04 13:37
chadmedive been very nasty to my ssds over the past few weeks on 6.15.x and theyre still here#asahi-dev · 2025-08-04 08:34
chadmedi cant imagine that mattering _that_ much anyway but ik there were cts issues between the pro and max so who knows#asahi-dev · 2025-08-04 08:33
chadmedoh yeah right that is wasteful