#
✕ nick:amarioguy
#asahi-dev · 2022-08-25 14:27
amarioguyyep, the fix works with different kernels too :^)
#asahi-dev · 2022-08-25 14:03
amarioguydid testing with a 13.0 development kernel and symbols are showing up just fine
#asahi-dev · 2022-08-25 14:03
amarioguythe PR will be up shortly
#asahi-dev · 2022-08-25 14:02
amarioguymainly a bool that indicates if we're using XNU symbols and the macho.vmin value passed in from load_macho (this is 0 if you're loading a raw image) so XNU syms should work as they did before the hv raw binary patch
#asahi-dev · 2022-08-25 14:00
amarioguyit actually was a pretty simple fix, but i did need to add parameters to load_raw to make that possible without messing with non-XNU paths
#asahi-dev · 2022-08-25 14:00
amarioguybtw i fixed the sym_offset issue
#asahi-dev · 2022-08-25 11:23
amarioguysince run_guest_kernel.sh does rely on that commit to an extent (it uses the -r switch) that is fairly urgent so the PR fixing the issue should be in by today
#asahi-dev · 2022-08-25 11:21
amarioguysven: i saw your comment about losing sym_offset, i'll look at the code again today and fix that errata
#asahi-dev · 2022-08-20 22:17
amarioguyacknowledges request
#asahi-dev · 2022-08-20 20:07
amarioguywill note that
#asahi-dev · 2022-08-20 20:07
amarioguyi was just unsure where i wanted to base it since again first time sending to lists
#asahi-dev · 2022-08-20 20:06
amarioguyright, i'll note that moving forward, i did test in torvalds's tree and it worked just to be sure
#asahi-dev · 2022-08-20 20:04
amarioguy(before today's update to clarify)
#asahi-dev · 2022-08-20 20:03
amarioguysven: i based off the asahi branch
#asahi-dev · 2022-08-20 19:48
amarioguymy bad, if i get a response i'll cc it (i just used the output of get_maintainers to stay safe, i'll remember to cc that moving forward)
#asahi-dev · 2022-08-20 19:48
amarioguywell it's on lore, with the right names and all (though the lack of email addrs may be because i use outlook)
#asahi-dev · 2022-08-20 19:46
amarioguyfirst time i used git send-email lol
#asahi-dev · 2022-08-20 19:46
amarioguyalright sven just sent the patch email, hopefully i didn't screw up too awfully
#asahi-dev · 2022-08-20 15:00
amarioguysince i'm submitting it as one patch and not a series
#asahi-dev · 2022-08-20 15:00
amarioguyto be safe i should probably apply my patches to a clean copy of the tree i suppose
#asahi-dev · 2022-08-20 14:51
amarioguyah true
#asahi-dev · 2022-08-20 14:51
amarioguyalright perfect, lemme get a clean tree, get the patches ready, i'll cc you on the emails once they're done
#asahi-dev · 2022-08-20 14:48
amarioguydon't mean to ping you too much btw, just making sure things are good before i start preparing things for upstreaming
#asahi-dev · 2022-08-20 14:47
amarioguysince i'm not sure if the old pasemi systems will use this path
#asahi-dev · 2022-08-20 14:47
amarioguyhttps://github.com/amarioguy/linux/commit/5731e5bbfadb293652dc7b64ad32d7a9e4c16867 i put init_completion in the platform probe for now is that fine
#asahi-dev · 2022-08-20 14:47
amarioguysven - figured i'd give a status update, we boot to userspace successfully now without issue after fixing the enable/disable bits, some minor pointer issues and not being an idiot and forgetting to init the completion for the first time (that last one hung me up for some time lol)
#asahi-dev · 2022-08-20 14:28
amarioguyamarioguy attempts to figure out if i2c should be a patch series or one giant patch
#asahi-dev · 2022-08-20 01:32
amarioguyyea ofc definitely needed the other changes too
#asahi-dev · 2022-08-20 00:37
amarioguystill need to run all the other things though like getmaintainers and all (btw for anyone who needs to review it's on the same page as before)
#asahi-dev · 2022-08-20 00:36
amarioguyonly thing i'm not sure on at this point is where we want the init_completion call, right now i put it in the pasemi_platform_i2c_probe func after common probe is called, but otherwise assuming we don't see further issues seems like the bulk of the patch is done
#asahi-dev · 2022-08-20 00:32
amarioguypovik: turns out that was the change we needed all along lol, we boot to userspace and the irq path seems to work without a hitch
#asahi-dev · 2022-08-20 00:26
amarioguyYES
#asahi-dev · 2022-08-20 00:26
amarioguyit works!!!!!!!!!!
#asahi-dev · 2022-08-19 23:59
amarioguyand that also explains the null pointer dereference too
#asahi-dev · 2022-08-19 23:59
amarioguythat explains a *lot*
#asahi-dev · 2022-08-19 23:59
amarioguy*oh*
#asahi-dev · 2022-08-19 23:42
amarioguyit's just the latest commit, same url as before
#asahi-dev · 2022-08-19 23:41
amarioguysquashed and force pushed the commits, should be ready for review now
#asahi-dev · 2022-08-19 23:30
amarioguyalright
#asahi-dev · 2022-08-19 23:26
amarioguythough fwiw the lockups were occurring with standard loglevels but still never touched the sound code
#asahi-dev · 2022-08-19 23:26
amarioguythat's part of the sound code which is bizarre (note that i did enable maximum debugging due to the panic issues i was facing earlier, and i've been booting with the debug arg so idk if that's why that's coming up)
#asahi-dev · 2022-08-19 23:23
amarioguyagain apologies if i'm running into "trivial" issues
#asahi-dev · 2022-08-19 23:22
amarioguyhttps://github.com/amarioguy/linux/tree/pasemi-i2c-changes - it's the latest 3 commits this time
#asahi-dev · 2022-08-19 23:21
amarioguyhttps://pastebin.com/M3VUAtkT here's the output
#asahi-dev · 2022-08-19 23:09
amarioguywill do in a sec
#asahi-dev · 2022-08-19 22:58
amarioguyi can send a kernel log here if needed, i can also push my changes for further review)
#asahi-dev · 2022-08-19 22:57
amarioguyone CPU seems to be deadlocked and i think there's a chance there's still a null pointer dereference somewhere
#asahi-dev · 2022-08-19 22:57
amarioguyhmm still encountering lockups (i had panics but that was solved by casting smbus to a void pointer in the request_irq call, i accidentally had a pointer to a pointer which caused issues)
#asahi-dev · 2022-08-19 22:44
amarioguyit gets stuck on "vectoring to next stage" occasionally without actually jumping to the kernel
#asahi-dev · 2022-08-19 22:44
amarioguybtw as a side note sometimes m1n1 won't be able to vector to the next stage when running run_guest_kernel.sh

plus ›