#asahi · 2021-11-19 17:49
svenat least looked at the nvme code again today :D#asahi · 2021-11-19 17:44
svenI guess self-hosted development might work for modules but that would still be annoying. It’s hard to be ./runlinux.sh and wait maybe 10seconds until the new kernel is booted#asahi · 2021-11-19 12:59
svenfor usb-c hotplug you'll also need additional patches that haven't been reviewed yet#asahi · 2021-11-19 10:48
svenouch#asahi · 2021-11-19 09:44
svenbgb: yes, the latest version is somewhere on the mailing list#asahi · 2021-11-19 09:44
svenkettenis: nice :D#asahi · 2021-11-19 09:27
svenugh, SW:Linux is severely outdated#asahi · 2021-11-19 08:57
sventhose have been working since pcie support has been merged#asahi · 2021-11-18 21:05
svenso the task is more "clean up nvme and while doing that do error recovery correctly"#asahi · 2021-11-18 21:04
sventhat nvme code needs quite some cleanup anyway#asahi · 2021-11-18 21:03
svenit's not done because i've been too lazy :D#asahi · 2021-11-18 18:29
svenso I think this fails so badly because some command times out and then the error recovery path just doesn’t work correctly for ANS#asahi · 2021-11-18 18:28
svenAh, nope, i was just confused.#asahi · 2021-11-18 18:25
sven*or do I #asahi · 2021-11-18 18:25
svenOr so I… ugh… it’s been too long since I looked at that code#asahi · 2021-11-18 18:24
svenAh, yes, so maybe ans does support the normal abort command after all. I just accidentally send them to the IO instead of the admin queue. Whoops.#asahi · 2021-11-18 18:21
svenhrm… it also looks like it tried to send the abort command to the io queue?!#asahi · 2021-11-18 18:18
svenWhich tree is that? t6000-bringup?#asahi · 2021-11-18 18:14
svenMakes more sense now. Some command timed out and then it dies because the normal error recovery just doesn’t work#asahi · 2021-11-18 18:12
svenso that makes sense. #asahi · 2021-11-18 18:12
svenWait.. that is a 8 in the “invalid opCode” message #asahi · 2021-11-18 18:10
svenAFAIK ANS just doesn’t support the nvme abort command but that would be opcode 8 and not 0#asahi · 2021-11-18 18:09
svenThe unwritable until reboot is because I need to fix the error recovery paths #asahi · 2021-11-18 18:08
svenHmmm… those nvme errors look odd. I know that the normal error handling doesn’t work too well with ANS. We’re there any errors before that or is that timeout the first one?#asahi · 2021-11-18 13:28
svenlol#asahi · 2021-11-18 13:26
svenand the USB curse strikes again!#asahi · 2021-11-18 13:26
sven:D#asahi · 2021-11-18 13:25
svenhrm, looks like the linux driver also does the tight command completion polling loop even though there is an interrupt it could use#asahi · 2021-11-18 13:24
svenyup#asahi · 2021-11-18 13:24
svenwell, it's related#asahi · 2021-11-18 13:23
svenoh, ouch on that DoS#asahi · 2021-11-18 11:51
svenoh#asahi · 2021-11-18 11:50
svenhm?#asahi · 2021-11-18 09:58
svenhrm, true#asahi · 2021-11-18 09:58
sven*CMD2 instead of CMD1#asahi · 2021-11-18 09:58
svenat least in theory the second port is supposed to use CMD2 instead of CMD2#asahi · 2021-11-18 09:57
svenugh. that would be annoying#asahi · 2021-11-18 09:53
svenfirefox317: marcan did fix some bug that resulted in the same issue a while ago so an old m1n1 would explain that#asahi · 2021-11-18 09:52
svenradnic: huh, TPS_REG_CMD1 should always only be 4 bytes#asahi · 2021-11-18 07:58
svenbut i don't think we actually read from that one#asahi · 2021-11-18 07:58
svenif it's for that DATA register that's expected#asahi · 2021-11-18 07:57
sven(or rather for which register)#asahi · 2021-11-18 07:57
svenfor which command?#asahi · 2021-11-17 20:04
svenawesome, thanks!#asahi · 2021-11-17 18:29
svenmarcan: just pushed a small change for the t6000 dart changes (of_device_get_match_data instead of open-coding it). if that still works on the pro/max i'll submit that series as well#asahi · 2021-11-17 16:31
svenpagetable fix #asahi · 2021-11-17 16:31
svenmarcan: don’t forget the arm#asahi · 2021-11-17 16:27
svenyeah, I have everything incoming blocked in my router just because I don’t want to spend my energy auditing random devices like my printer #asahi · 2021-11-17 12:56
sveneven afterwards i don't really see a reason to skip it given how small the watchdog driver is#asahi · 2021-11-17 07:06
sven:D