#
✕ nick:radnic
#asahi · 2021-11-18 13:47
radnicMakes sense. Silly me.
#asahi · 2021-11-18 13:46
radnicAh... missed that.
#asahi · 2021-11-18 13:45
radnic*reiterate
#asahi · 2021-11-18 13:45
radnicBut I see no case when you woudl reaiterate. Either you try once and it's OK or you exit,
#asahi · 2021-11-18 13:41
radnicWHat is the point of the do while.
#asahi · 2021-11-18 13:40
radnicif the commands fails to run ,you won't reitereate, you'll just exit.
#asahi · 2021-11-18 13:40
radnic } while (cmd_status != 0);
#asahi · 2021-11-18 13:40
radnic udelay(100);
#asahi · 2021-11-18 13:40
radnic return -1;
#asahi · 2021-11-18 13:40
radnic if (i2c_smbus_read32(dev->i2c, dev->addr, TPS_REG_CMD1, &cmd_status))
#asahi · 2021-11-18 13:40
radnic if (cmd_status == TPS_CMD_INVALID)
#asahi · 2021-11-18 13:40
radnic return -1;
#asahi · 2021-11-18 13:40
radnic do {
#asahi · 2021-11-18 13:40
radnicone question though, in here:
#asahi · 2021-11-18 13:40
radnicYes, works :)
#asahi · 2021-11-18 13:28
radnicNever retrying again?
#asahi · 2021-11-18 13:28
radnicAnd exit.
#asahi · 2021-11-18 13:28
radnicIt will fail after the first poll.
#asahi · 2021-11-18 13:28
radnicwell, yeah, because you put the delay at the end.
#asahi · 2021-11-18 13:26
radnicair 13
#asahi · 2021-11-18 13:26
radnicLet me make sure before I lead you down a chase
#asahi · 2021-11-18 13:26
radnicboth 0 and 1 case
#asahi · 2021-11-18 13:26
radnicUhhh.. I still get the problem. :))
#asahi · 2021-11-18 13:20
radnicdoesn't matter*
#asahi · 2021-11-18 13:20
radnicIsn't 10ms too much? Eh, never mind, probably doesn'
#asahi · 2021-11-18 13:18
radnicThat's why the delay there let it pass. Managed to finish its stuff.
#asahi · 2021-11-18 13:18
radnicOk, funnily enough, I saw this happen in another life on another chip. Makes sense.
#asahi · 2021-11-18 13:17
radnicAh, that do while.
#asahi · 2021-11-18 13:16
radnicNo, wait, I thouthg we're DoS'ing it hereval & PASEMI_RX_FLAG_EMPTY && --timeout
#asahi · 2021-11-18 13:15
radnicIs there firmware in the I2C peripherial?? That sounds... wierd.
#asahi · 2021-11-18 13:13
radnic(thankfully there is a magic USB-PD command to put those on the type C pins...) that is soo cool, so you can see the i2c off a split cable? :))
#asahi · 2021-11-18 13:01
radnicHah, accidental discoveries, got to love them.
#asahi · 2021-11-18 12:29
radnicyou can try it if it's not too big of a pain.
#asahi · 2021-11-18 12:29
radnicNot chainloading.
#asahi · 2021-11-18 12:29
radnicmanually rebooting.
#asahi · 2021-11-18 12:28
radnicleaving that, I never got it in 20x boots.
#asahi · 2021-11-18 12:28
radnicremoving that, I get the same as you reported.
#asahi · 2021-11-18 12:28
radnicmdelay(100);
#asahi · 2021-11-18 12:28
radnicAfter i2c_smbus_write(dev->i2c, dev->addr, TPS_REG_CMD1, (const u8 *)cmd, 4) I had a
#asahi · 2021-11-18 12:27
radnicI had an extra delay put in the system;. Removing that, I get the same result as you do.
#asahi · 2021-11-18 12:27
radnicOk, got in the same state as you.
#asahi · 2021-11-18 12:23
radnicPossible.
#asahi · 2021-11-18 12:21
radnicBut that's it.
#asahi · 2021-11-18 12:21
radnic*have
#asahi · 2021-11-18 12:21
radnicI ahve extra cnahges as in... extra prints.
#asahi · 2021-11-18 12:20
radnicI can confirm that.
#asahi · 2021-11-18 12:19
radnicIt seems it broke _both_ devices now.
#asahi · 2021-11-18 12:19
radnicYep, that is what I have.
#asahi · 2021-11-18 12:18
radnicConsistenly or ocassionally?
#asahi · 2021-11-18 12:18
radnicNever saw it after

plus ›