#asahi · 2021-08-10 12:26
j_eyamw: are you on air or mbp?#asahi · 2021-08-10 12:22
j_eyamw: woot!#asahi · 2021-08-10 10:46
j_eyyeah you still need an interrupt parent on spi3, line 290#asahi · 2021-08-10 10:44
j_eyamw: ok, push again, I might test later#asahi · 2021-08-10 10:41
j_eyhm#asahi · 2021-08-10 10:37
j_eyaic on spi3, nub_gpio on keyboard (for the interrup parents)#asahi · 2021-08-10 10:37
j_eyoh wait, you dont have on interrupt-parent = <&aic>; on spi3#asahi · 2021-08-10 10:35
j_eymaybe it didnt link properly, i mean change the keyboard@'s interrupt parent back to the nub_gpio again#asahi · 2021-08-10 10:32
j_ey(and then probably change the clock back to &spi3_clk, but maybe it doesnt matter..)#asahi · 2021-08-10 10:31
j_eyso basically undo this snippet https://github.com/amworsley/AsahiLinux/commit/aa1e2fd763667f41992b05f838674197f7e8a197#diff-845c07f30f0f94856b22d7b50c0ff3d27a961abeffefcdfab01f2e8cd64569ccL300#asahi · 2021-08-10 10:31
j_ey(and remove the aic one for the keyboard)#asahi · 2021-08-10 10:30
j_eyamw: //interrupt-parent = <&nub_gpio>; put this back#asahi · 2021-08-10 10:28
j_eyamw: can you repush your branch?#asahi · 2021-08-10 10:20
j_eyhm#asahi · 2021-08-10 10:20
j_eyI had a bunch of SErrors but they went away after I forced that option to be true#asahi · 2021-08-10 10:19
j_eyNope meaning, you tried hardcoding it to be true in clk.c and it still didnt work?#asahi · 2021-08-10 10:15
j_eyor try the patch I posted a bit ago#asahi · 2021-08-10 10:13
j_eytry the above first#asahi · 2021-08-10 10:12
j_eyin drivers/clk/clk.c try force it by writing: if (1 || clk_ignore_unused) {#asahi · 2021-08-10 10:11
j_eyI dont think its working then#asahi · 2021-08-10 10:10
j_ey disabling unused clocks" in dmesg?#asahi · 2021-08-10 10:10
j_eyamw: do you see "clk: Not#asahi · 2021-08-10 09:53
j_eyamw: yeah but you need one for pinctrls and spi3 too#asahi · 2021-08-10 09:51
j_eyI think that fixes that#asahi · 2021-08-10 09:49
j_eyamw: on both pinctrls and the spi3#asahi · 2021-08-10 09:49
j_eyyou need interrupt-parent = <&aic>;#asahi · 2021-08-10 09:48
j_eyoh one sec#asahi · 2021-08-10 09:47
j_eyamw: yeah mainline has the aic already#asahi · 2021-08-10 09:09
j_eyunless you removed it#asahi · 2021-08-10 09:09
j_eythe irq code is in the patches you took#asahi · 2021-08-10 09:05
j_eyweird, that just worked for me#asahi · 2021-08-10 09:03
j_eylike the platform_get_irq stuff?#asahi · 2021-08-10 09:03
j_eyamw: oh, do you mean failing to get an interrupt during probe?#asahi · 2021-08-10 09:01
j_eyamw: hm, which bits didnt you take?#asahi · 2021-08-10 08:56
j_eyyeah, so that option isnt being set properly #asahi · 2021-08-10 08:53
j_eyamw: cool, but as pipcet[m] said.. that probably shouldnt be called. double check youre getting "clk: Not disabling unused clocks" in dmesg#asahi · 2021-08-10 08:51
j_eybut ignoring the unused clocks makes that patch not needed#asahi · 2021-08-10 08:51
j_eyamw: https://paste.gg/p/anonymous/c327152acdf84704a11e4aac87f020e4 too#asahi · 2021-08-10 08:51
j_eyoh weird#asahi · 2021-08-10 08:50
j_eyamw: did you pass ^?#asahi · 2021-08-10 08:36
j_eyamw: also pass clk_ignore_unused on the kernel command line#asahi · 2021-08-10 08:35
j_eyyeah you need that commit ^#asahi · 2021-08-10 08:35
j_eyamw: Add PMGR power-state based clock gates for Apple SoCs.#asahi · 2021-08-10 08:30
j_eyamw: and you've enabled all the CONFIGs? PINCTRL_APPLE_GPIO, SPI_APPLE_MC, KEYBOARD_APPLESPI?#asahi · 2021-08-10 08:25
j_eyamw: for the delay thing replace it with 'ndelay(spi_delay_to_ns(&t->delay, t));' dont delete it#asahi · 2021-08-10 08:24
j_eysame lnk#asahi · 2021-08-10 08:20
j_eyamw: can you make a branch with your changes? I can look, I got this working yesterday, but cant share it immediately#asahi · 2021-08-10 08:20
j_eysorry nvm = nevermind#asahi · 2021-08-10 08:19
j_eyoh nvm you got them compiling#asahi · 2021-08-10 08:19
j_eyamw: added the CONFIG_ options?