#asahi · 2021-04-07 20:58
arndsven: maybe also loop in Jean-Philippe Brucker <jean-philippe@linaro.org>, he's jbru on #armlinux. Will is wildea01 there, fwiw. I don't know if Robin Murphy is on IRC, but he's the one that added the BUG_ON() when implementing support for multiple i/o page sizes#asahi · 2021-04-07 20:21
arndsven: it also appears that you will hit that BUG_ON() in init_iova_domain() when setting up the domain for the dma-mapping API. I'm fairly sure that it is possible to lift that restriction, but I don't know how invasive the changes will be for that.#asahi · 2021-04-07 20:12
arndso no SVA, no vfio, and no probably no GPU with with per-task contexts#asahi · 2021-04-07 20:11
arndhowever, anything that relies on controlling the iommu from the driver directly will have a problem#asahi · 2021-04-07 20:10
arndsven: the dma-mapping API does not guarantee dma_map_sg() to produce a consecutive bus address range even with an IOMMU, so for normal drivers it should be fine even when the iotlb page size is larger than the CPU page size. You still get the isolation and address-expanding properties#asahi · 2021-04-07 15:16
arndwe can still debate over whether I should merge in the VHE branch into the soc tree after that makes it into the arm64 tree#asahi · 2021-04-07 15:14
arndI'll be busy with the backlog of other pull requests for the rest of my day here, so no need for you to loose sleep over doing it today. If you send it by tomorrow, I'll pull it in right away#asahi · 2021-04-07 15:13
arndmarcan: ok, please just drop the VHE patches from the branch, and send that pull to soc@kernel.org with cc to everyone that commented in the past, and explain the situation with all the dependencies in the tag.#asahi · 2021-04-07 15:08
arndnevermind, I see it's needed to build the aic driver#asahi · 2021-04-07 15:07
arndmaz: if we merge the m1 support without the VHE patches, do we still need the FIQ patches to cleanly build, or should marcan drop those as well then?#asahi · 2021-04-07 15:05
arndthe worst case would be someone needing to bisect an m1 specific (boot time, I guess) regression that is caused by something else merged into v5.13. In this case, "someone" most likely ends up being marcan, and he can figure it out regardless ;-)#asahi · 2021-04-07 15:00
arndtrue#asahi · 2021-04-07 14:59
arndOr I could merge the rest into a standalone branch, and then merge the VHE patches on top after they make it into the arm64 tree#asahi · 2021-04-07 14:58
arndobviously if we expect that to take longer, that is something we can reconsider#asahi · 2021-04-07 14:58
arndmaz: I said earlier that I'd prefer the branch to have all the patches to make it work (not just build) in one piece#asahi · 2021-04-07 14:57
arndmarcan: in this case, it makes sense to start the tag description with '[DONT PULL]' and an explanation#asahi · 2021-04-07 14:56
arndmarcan: ok, got it#asahi · 2021-04-07 14:47
arndok#asahi · 2021-04-07 14:40
arndor do these just go through the soc tree without showing up in the arm64 tree as well?#asahi · 2021-04-07 14:40
arndI'm still confused about the nVHE patches, the tag you sent now has these at the bottom after the other two merges. Shouldn't this be a merge commit to get the same commits that make it into the arm64 tree?#asahi · 2021-04-07 14:39
arndI think there is a slight preference for https://#asahi · 2021-04-07 14:36
arndgit request-pull just pastes the tag description, so that makes it in there automatically#asahi · 2021-04-07 14:36
arndI don't care about the tag name for the purpose of the pull request, I'd say including v5 in the name makes sense unless it's unchanged from v4#asahi · 2021-04-07 14:35
arndI don't know what the latest is on keeping the change nodes in the tag description. I usually don't do it myself, but I've seen others do it#asahi · 2021-04-07 14:35
arndthe tag description should not contain the '[PATCH v4]' prefix on the subject line#asahi · 2021-04-07 14:34
arndI usually also add a Signed-off-by line to a tag, though some others don't#asahi · 2021-04-07 14:34
arndmarcan: github is fine, but the tag description should be more than one line. You can probably just copy most of the v4 cover-letter text into that#asahi · 2021-04-07 10:13
arndmarcan: fwiw, https://www.kernel.org/doc/html/latest/process/maintainer-pgp-guide.html seems to suggest that ed25519 is preferred over rsa2k keys, no need to worry about old pgp versions here#asahi · 2021-04-07 10:07
arndit's slightly annoying to have linux do a complete PCI bus/resource assignment even when the firmware has done it correctly already, but somehow we ended up doing that on most machines#asahi · 2021-04-07 10:05
arndkettenis_: I suppose this means we don't put a /chosen/linux,pci-probe-only property in the DT, but u-boot may add this to speed up the boot#asahi · 2021-04-07 08:57
arndmarcan: please sign the PR with the key that you plan to use in the future, even if that doesn't have any signatures from other developers yet#asahi · 2021-04-07 08:56
arndok#asahi · 2021-04-07 08:55
arndRemind me what the VHE series is for, is that also required for booting?#asahi · 2021-04-07 08:54
arndI would much prefer to have a branch that actually works standalone#asahi · 2021-04-07 08:53
arndmarcan: isn't the tty series also needed in order to boot with a serial console?#asahi · 2021-04-07 08:50
arndright, I thought that's what you had already done last week#asahi · 2021-04-07 08:48
arndmaz: ok, fair enough#asahi · 2021-04-07 08:48
arndmarcan: can you send that pull request in the next two days then? I don't want to merge it too late, and it seems there won't be an -rc8 this time after all#asahi · 2021-04-07 08:46
arndmaz: I see you gave a Reviewed-by for the irqchip driver. Do you think we should also get an Acked-by from tglx for merging it through the soc tree in addition?#asahi · 2021-04-07 08:45
arndmarcan: regarding the v4 submission, it seems that there were only very minor comments that you can just fix up and send a v5 pull request with any additional changes as fixups on top.#asahi · 2021-04-07 07:40
arndshenki: it looks like that tg3 firmware is always flashed into the chip though, so no need to load any blob (open source or not) into the device for network booting#asahi · 2021-04-06 15:55
arndthe last time new tg3 PCI IDs were added was in 2013#asahi · 2021-04-06 15:52
arndThis is old hardware, the driver has (c) 2001#asahi · 2021-04-06 15:51
arndThe tg3 driver has code to load firmware from user space, but it's only 3 to 7 KB, and apparently many variants have that in the builtin eeprom#asahi · 2021-04-06 14:53
arndrobher: ah, nice. I had not looked in the soc specific dwc files, so I missed that#asahi · 2021-04-06 14:38
arndThe main use that I could see would be USB keyboard and mass storage support on the Type A ports#asahi · 2021-04-06 14:37
arndI think u-boot has a port of the Linux USB network drivers, so it can support a lot of hardware#asahi · 2021-04-06 14:27
arndnot sure what marcan's long-term plan is for the scope of what to support in m1n1#asahi · 2021-04-06 14:27
arndunless m1n1 wants to support booting from a PCIe attached device (network, usb storage, ...) itself#asahi · 2021-04-06 14:26
arndbus scanning and resource assignment probably makes sense to keep in u-boot, since that is complicated and u-boot has platform independent code for it