#
✕ nick:arnd
#asahi · 2021-10-27 12:25
arndAcked-by: arnd
#asahi · 2021-10-27 12:25
arndSigned-off-by: j_ey
#asahi · 2021-10-27 12:24
arndyou could still have it done indirectly, so a patch might be
#asahi · 2021-10-27 12:23
arndI meant removing the one for the same person. Acked-by usually means that you are okay with the commit being merged by someone else. If you are the one merging it, then it's redundant
#asahi · 2021-10-27 12:22
arndif you are adding SoB, you can remove the 'Acked-by'
#asahi · 2021-10-27 12:21
arndmarcan: the two commits from the fixes branch are already in mainline now, so don't rebase those
#asahi · 2021-10-27 12:05
arndmarcan: your branches are right on top at the moment, if you resend a fixed pull request, I can back them out and redo the merge
#asahi · 2021-10-27 06:50
arndno worries, as I said there is no good way of doing it. As long as your branch has no backmerge, the shortlog in the pull request is still sensible.
#asahi · 2021-10-27 06:32
arndmarcan: the generated pull request for the maintainers file update included the two commits that I had already pulled into the fixes branch, which was a bit confusing. There is no good way of doing that, but I would usually pass the old branch as the base commit in 'git request-pull' here
#asahi · 2021-10-27 06:26
arndah, those are just for the newly added files. Nevermind then, it's arm/soc then, not arm/fixes
#asahi · 2021-10-27 06:24
arndLinux just merged my fixes branch, which I think is the last one for this release. I'll put your maintainer updates into arm/fixes, but plan to send that next week along with the new stuff then.
#asahi · 2021-10-27 06:22
arndmarcan: it's unlikely, he already said that he'll likely release 5.15 this week,
#asahi · 2021-10-20 09:23
arndrkjnsn[m]: 'lscpu' shows "Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 asimddp sha512 asimdfhm dit uscat ilrcpc flagm sb dcpodp flagm2 frint", so both the CRYPTO_AES_ARM64_CE ("aes") and CRYPTO_AES_ARM64_NEON_BLK ("asimd") variants of the kernel's AES code should work, and it will pick the fastest one at runtime
#asahi · 2021-10-18 13:07
arndalyssa: I had not even noticed that MFD regmap bit, only the main driver. Any idea what the MFD side is good for? For the actual spmi driver, it's mostly the irqchip bits that I suspect need changes after a thorough review. The interrupt-hopping data transfer looks inefficient, but there is probably not much to be done about that in the driver.
#asahi · 2021-10-18 12:43
arndI have no business in drm-misc, or at least I keep saying no whenever I'm offered commit access
#asahi · 2021-10-18 12:43
arndthanks
#asahi · 2021-10-18 12:24
arndI just looked at the corellium rtc driver, the code looks "obvious", but I think we'd need to replace the two DT properties with normal "reg" properties, and of course it needs the spmi driver first, and that seems likely to need more changes, or at least a more detailed review
#asahi · 2021-10-18 12:14
arndalyssa: do you have a link to your version of those drivers?
#asahi · 2021-10-08 12:27
arndthey look more like the result of convergent evolution than being actually the same
#asahi · 2021-10-08 12:27
arndfirefox317: I'm pretty sure it's different enough from all the ones in mainline linux. I looked through them in the past, and there are a number of other drivers that sort-of all do the same things, but each of them have different register offsets.
#asahi · 2021-10-07 16:07
arndok
#asahi · 2021-10-07 15:33
arndif you want to do it the fancy way, you can have a shared branch with the bindings, and then base the driver changes and the dts changes on top of that branch, sending them both ways with identical commit IDs for the bindings
#asahi · 2021-10-07 15:32
arndit can go either way: some subsystem maintainers like to pick these up together with the drivers, anything you have left over can go together with the dts files
#asahi · 2021-10-07 14:47
arndmarcan: the branches in the soc tree for the merge window are based on -rc3 at the moment, so that would also work, but I want to avoid back-merging contents from mainline, in order to preserve a readable git history. Sticking with -rc1 as a rule means you don't have to worry about which -rc I'm basing on
#asahi · 2021-10-07 14:46
arndmarcan: make it the earliest -rc that it is known to work on, normally -rc1
#asahi · 2021-10-07 14:40
arndone email per pull request
#asahi · 2021-10-07 14:40
arndprobably yes, depends on whether any of your DT changes are stable material
#asahi · 2021-10-07 14:39
arndmarcan: when you send fixes, a combined branch is fine, anything for the merge window should be split into categories DT, defconfig, drivers, etc
#asahi · 2021-10-07 14:38
arndmarcan: I assume there was no earthquake damage in your office then
#asahi · 2021-10-07 14:37
arndyes, I have not sent out the fixes branch yet, working on that
#asahi · 2021-10-06 19:12
arndyes, definitely. there is a good chance it actually works, I just mentioned it so you don't accidentally break something important if you rely on it and it doesn't work
#asahi · 2021-10-06 18:55
arndnsklaus: not sure you can actually do a fresh install to an external drive without having a working macos on the internal one.
#asahi · 2021-10-06 18:47
arndI did manage to boot macOS from an external thunderbolt drive, the entire OS other than the pre-boot partition can be on that in principle, you just can't boot Linux that way (yet), and you can't do it on a non-thunderbolt USB drive
#asahi · 2021-10-05 08:39
arndhttps://youtu.be/mF10hgVIx9o?t=811 is mricon's recent plumbersconf presentation about the latest features and plans
#asahi · 2021-10-05 08:37
arndand if you want to pick up patches from that list, you can use 'b4' to interact with it, and it will even add links to the archive in the commit message
#asahi · 2021-10-05 08:36
arndregardless of where it goes, you should ask mricon to set up a lore.kernel.org mirror after that, it's super useful as a reference
#asahi · 2021-10-05 08:33
arndyou can ask postmaster@vger.kernel.org to add a list if you want it hosted there
#asahi · 2021-10-05 08:33
arndyes, I think having a mailing list would be good
#asahi · 2021-10-05 08:33
arndIt's better to be explicit here. cc:stable is obvious, and you can add the minimum kernel version it applies to (sometimes backporting a fix to an older kernel causes the opposite regression), and if you think a patch looks like a fix but should not be backported, just add a sentence in the description to explain why not
#asahi · 2021-10-05 08:31
arndSasha also has a set of scripts and AI logic to find patches that have no cc:stable tag but look like they should be backported
#asahi · 2021-10-05 08:30
arndyes, the cc:stable tag is mostly there to inform gregkh and that the patches are known to apply to older kernels as well
#asahi · 2021-10-05 08:29
arndhis process for stable kernels is otherwise very automated, so you don't need to worry about creating extra work due to the cc:stable tag
#asahi · 2021-10-05 08:28
arndgregkh often complains about patches marked as cc:stable but not sent as fixes for the current release, so he has to do a ton of backports to the just-released kernel after -rc1 comes out with all those fixes in it
#asahi · 2021-10-05 08:27
arndand in general I would assume that anything you want fixed in the current release cycle should also be fixed in stable trees, and vice versa
#asahi · 2021-10-05 08:26
arndI wouldn't make a distinction between dts files and code here
#asahi · 2021-10-05 08:26
arndAdding a "Cc: stable@vger.kernel.org" tag for stable backports usually makes sense if the current code is definitely wrong and the fix you do would also address the same problem on stable kernels.
#asahi · 2021-10-05 08:24
arndmarcan: dt patches can be important fixes, this is generally your call to make to weigh the importance of the fix against possible regression risks. Generally I would prefer platform maintainers to categorize more patches as fixes for the current release though
#asahi · 2021-10-05 08:22
arndmost maintainers send pull requests even if it's just one or two bugfixes, but feel free to send the fixes as individual patches if there are only a couple and it's a hassle to set up a git tree for it
#asahi · 2021-10-05 08:21
arndI'm a bit behind this release but I plan to pull in all remaining fixes today
#asahi · 2021-10-05 08:20
arndmarcan: yes, same thing there: send bug fixes as soon as you can, batching things up over one or two weeks at most

plus ›