#
…

2021-02-11

00:14acelogic2 has quit [Ping timeout: 272 seconds]
00:16odmir has quit [Remote host closed the connection]
00:17odmir has joined #asahi
01:00davidrysk[m]kettenis: are you saying that writing to E2H has an effect?
01:02acelogic has joined #asahi
02:33marcandavidrysk[m]: on other CPUs, I assume
02:51PendulumSwinger has quit [Quit: The Lounge - https://thelounge.chat]
03:18phiologe has quit [Ping timeout: 258 seconds]
03:19phiologe has joined #asahi
03:46acelogic has quit [Ping timeout: 240 seconds]
03:49balrog has quit [Ping timeout: 265 seconds]
03:50robinp has joined #asahi
03:57balrog has joined #asahi
04:34Tokamak_ has joined #asahi
04:37Tokamak has quit [Ping timeout: 246 seconds]
04:58Tokamak_ has quit [Read error: Connection reset by peer]
04:58Tokamak has joined #asahi
04:59marvin24 has quit [Ping timeout: 240 seconds]
05:00marvin24 has joined #asahi
05:05ky0ko has quit [Read error: Connection reset by peer]
05:07acelogic has joined #asahi
05:26linux-superman has joined #asahi
05:28will1 has joined #asahi
05:40linux-supermaniLinux OS 2 is released and it is based on Debian 10 Stable! https://ilinuxos.com
06:06linux-superman has left #asahi [#asahi]
06:12suskun has joined #asahi
06:12suskun has quit [Remote host closed the connection]
06:28VinDuv has joined #asahi
06:51randompasser has joined #asahi
06:59VinDuv has quit [Quit: Leaving.]
06:59randompasser has quit []
07:03maor26 has joined #asahi
07:04mndza has joined #asahi
08:12Tokamak has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
08:21roxfan2 has joined #asahi
08:22roxfan has quit [Ping timeout: 265 seconds]
09:00ConeOfAttack[m] has quit [Quit: Idle for 30+ days]
09:00wolf511[m] has quit [Quit: Idle for 30+ days]
09:00botoxparty[m] has quit [Quit: Idle for 30+ days]
09:00khronokernel[m] has quit [Quit: Idle for 30+ days]
09:04mazdavidrysk[m]: The only valid fixed value for HCR_EL2.E2H is 0. Having it being stuck to 1 is not legal.
09:05zkrx has quit [Ping timeout: 256 seconds]
09:07Bublik has joined #asahi
09:21zkrx has joined #asahi
09:30Empus has quit [Quit: quit]
09:32Empus has joined #asahi
09:32qyousef has quit [Ping timeout: 272 seconds]
09:33qyousef has joined #asahi
09:39Mary_ has quit [Quit: Bye!]
09:41Mary_ has joined #asahi
09:49TheJollyRoger has quit [Remote host closed the connection]
09:50TheJollyRoger has joined #asahi
10:34XeR has quit [Remote host closed the connection]
10:45XeR has joined #asahi
10:45delrothmarcan: it says gzip not found in your dmesg
10:59raster has joined #asahi
11:12Bublik has quit [Ping timeout: 272 seconds]
11:13rwhitby has quit [Ping timeout: 264 seconds]
11:13rwhitby has joined #asahi
11:14acelogic has quit [Ping timeout: 256 seconds]
11:23brandas has quit [Ping timeout: 272 seconds]
11:23brandas_ has joined #asahi
11:31ponikrf[m] has joined #asahi
11:38choozy has joined #asahi
12:06hir0 has joined #asahi
12:26gabiruh has quit [Quit: ZNC 1.7.5 - https://znc.in]
12:26gabiruh has joined #asahi
12:36baryluk has quit [Quit: server kernel update. will be back]
12:39awordnot has quit [Ping timeout: 246 seconds]
12:39choozy has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
12:51Crisco has quit [Ping timeout: 264 seconds]
12:58Crisco has joined #asahi
13:22marcanmaz, kettenis, arnd, robher & co: still working on v2 as a whole, but the first take of the nGnRnE story is in the last 7 commits here if you want to take a look: https://github.com/AsahiLinux/linux/commits/upstream-bringup-v2-wip
13:27TheJollyRoger has quit [Remote host closed the connection]
13:27TheJollyRoger has joined #asahi
13:29modwizcodecool, seems a lot nicer that way
13:29dhewgdouble "require" in 2nd patch description
13:32modwizcodewhat is "the second patch"
13:33dhewgoh those 7 :)
13:33modwizcodeah see it now
13:35arndmarcan: when you add the ioremap_np(), I'd suggest also adding a fallback implementation in asm-generic/io.h and a devm_ioremap_np() wrapper in include/linux/io.h+lib/devres.c
13:35arndah, I see you just split it up more fine-grained, and the generic fallback is already there
13:36marcanyeah, it's in pretty small pieces
13:36marcandevm_ioremap_np too
13:37modwizcodeIsn't the ability to map without reserving kind of suspect? I feel like I remember reading about why that's not a thing
13:37marcantons of drivers do it though, manually
13:38marcane.g. the samsung one does it because it reserves/frees the region in other functions, though arguably it should be doing the mapping there too, but then the serial core is ancient and does not have the resource concept... so that would have to go in driver private stuff if we used that
13:39modwizcodeThe serial core is pre-reserving the memory (with the wrong attributes)?
13:39mazmarcan: I think this looks reasonable. there will be some corner cases, I'm sure. but the mapping between DT and resources seem OK.
13:39marcanno, the serial core has callbacks to reserve/release the region, but the structures used just have a base/size, so it loses the attributes if any if we go through that
13:39arndmarcan: I would find it slightly easier to review if you combine the patches into slightly larger chunks, but that's not important. I assume that I'll just end up merging the lot through the soc tree in the end
13:41marcanI wasn't sure how much individual maintainers of those bits would want it split up, but I can certainly e.g. combine the generic asm ioremap_np(), IORESOURCE_MEM_NONPOSTED, devm_ioremap_np patches into one
13:41marcan(if you think that makes more sense)
13:41modwizcodeI see, the serial core handles reservation seperately from mapping, but once it's reserved you can't use the mapping functions that reserve because it's already been reserved.
13:41arndyes, I think that would help me.
13:42marcanok, I'll do that in a bit (dinner first :))
13:42Bublik has joined #asahi
13:43marcanmodwizcode: I think the intent is the reserve/release functions should do the mapping too, but in the samsung driver the mapping is done ahead of time *before* reservation
13:43marcanhowever, the problem with moving mapping to the reserve/release functions is that by then the uart core thinks you just provided it with an mmio base/size to be mapped
13:43arndI'm still trying to form an opinion on the of_mmio_is_nonposted() semantics. My earlier thoughts were that it should only have an effect on direct children of the bus, but it seems that robher has some other ideas (not sure if your implementation matches those)
13:43marcanI think I implemented what robher described
13:43marcan(as I understood it anyway)
13:44marcani.e. walk up the tree until you find a positive/negative property, or until you hit a non-translatable boundary
13:44dhewgpatch#1 vendor prefix needs a new desc, that still describes AAPL
13:44arndI thought he only wanted to walk up the tree when there is an empty ranges property, but I may have misunderstood that
13:45marcandhewg: yeah, I'll go through all the commit messages
13:45marcanthat one's in my TODO
13:45marcanI just bulk s/AAPL/apple/ on everything
13:45dhewgalright
13:46arndThe only part I don't like in the series is the new devm_ioremap_resource_noreq() interface. I'd rather see the driver converted to either use devm_ioremap_resource(), or an open-coded devm_ioremap()
13:46marcanthe problem with the latter is we lose the flags... so that needs to be checked separately
13:46arndI need to check what it would take to use devm_ioremap_resource()
13:47arndyes, I understand about the flag, it would then either have to call of_mmio_is_nonposted() or decide based on the compatible string
13:47arndand both of these are slightly ugly as well, but are local to this driver
13:48marcanstm32-usart.c just uses dummies for request/release and devm_ioremap_resource
13:48marcanthat approach would work
13:48marcanthe whole serial API is... kind of antiquated anyway
13:48modwizcodeclassic work on a feature, you find the whole API is wrong :)
13:49marcanthere's a reason for Documentation/driver-api/serial/tty.rst which starts like this:
13:49marcan=================
13:49marcanThe Lockronomicon
13:49marcan=================
13:49marcanYour guide to the ancient and twisted locking policies of the tty layer and
13:49marcanthe warped logic behind them. Beware all ye who read on.
13:49modwizcodeyeah the TTY layer as a whole is... something else
13:50marcanarnd: honestly I think ditching _noreq and just doing what stm32-usart does is better
13:50modwizcodeimo it mashes too many things together for what anyone actually needs it to do.
13:50modwizcodeDefinitely think ditching _noreq if you can is good
13:50marcannot just that one too
13:51marcanheck there are more drivers doing that than plain devm_ioremap
13:51marcanso I think it should be fine
13:54arndmarcan: I don't see the code that actually does the registration you mention in the comment, where is that?
13:54arnds/registration/request_resource/
13:55marcanrequest_mem_region in s3c24xx_serial_request_port
13:55arndok, got it
13:56marcanarnd: I just changed it, ok to force push?
13:57marcandone. tested working fine.
13:57arndmarcan: fairly sure you can just remove the two now-empty callbacks completely
13:58arndotherwise looks good to me
13:59marcanha, I was wondering why all the other drivers had dummies
13:59marcana7cfaf165e changed it in 2016
13:59arndyep, just found that commit as well
14:00j`eymarcan: yay more cleanups!
14:01marcanarnd: re-pushed
14:01marcanpatches with more - than + are always the best kind
14:02j`eyyoure not going to beat arnd though, since he's deleting all those old platforms :P
14:03dhewg"earlycon" is still in the dts
14:03arndmarcan: the ioremap stuff all looks good to me, just needs a DT binding description for the new properties, and a confirmation from robher that these are the semantics he wants
14:04marcanyup, I have the binding in my TODO
14:04arndmarcan: how is the mapping done for earlycon?
14:04marcannot yet :)
14:04marcanthat needs a parallel implementation of the of stuff for FDTs
14:04arndok, then I can stop looking for that
14:04marcanand then just open-coding it in earlycon.c
14:05arndI wonder if you can just hardcode it to ioremap_np() in apple_m1_early_console_setup()
14:05mazI'd be tempted to use nGnRnE for fixmap device mappings by default if I was sure it wouldn't introduce any regression...
14:06marcanyeah, I was thinking of that
14:07marcanbbiab, got some takeout pizza :)
14:07marcanmaz: I think kettenis said they use nGnRnE for everything by default, which is some evidence that it isn't broken on other devices
14:08marcanI don't know if mapping the same region nGnRnE and nGnRE is legal though, per spec (which would happen for keep_bootcon on other platforms)
14:08robhermarcan, arnd: looks okay to me in terms of semantics. The only thing is we walk up the whole tree for everyone else on every node. I think we should bail out on !apple. See some of the other quirks in that file which save quirk enable/disable in a static var.
14:08mazmarcan: aliasing with different attributes can cause havoc in some interconnects.
14:09marcanthought so
14:10marcanrobher: just as an optimization?
14:10robhermarcan: yes
14:22modwizcodeI think I read that you're not supposed to alias with different attributes. But I couldn't find anything for V8 in the ARM about it except that it had very specific definitions for the behavior.
14:24marcanrobher: sure, I'll add something :)
14:24maor26 has quit [Read error: Connection reset by peer]
14:31arndmodwizcode: maybe earlycon can be a simple hack like
14:31modwizcodedid you mean marcan
14:33modwizcodeSlightly offtopic: Where do I want to look if I want to change a kernel page I have to writable?
14:33arndmodwizcode: we had some discussions about conflicting page attributes in Linux years ago, those proably resulted in the current language in the reference manual. I much preferred the powerpc behavior of causing a checkstop to be honest
14:34modwizcodeI was reading LWN articles about the issues I think
14:34modwizcodeI feel like not allowing multiple mappings with different attributes causes a lot of pain
14:35arndmodwizcode: maybe look at aarch64_insn_patch_text()
14:37arndmodwizcode: do you want to have it permanently writable, or just write something to it and then return it to read-only?
14:37marcanarnd: I think that kind of thing would work. It's certainly simple.
14:37modwizcodethe latter
14:37marcanI can just pull that in if you're OK with that
14:37arndyes, just add "Suggested-by: Arnd Bergmann <arnd@arndb.de>"
14:51acelogic has joined #asahi
14:56maor26 has joined #asahi
15:45imobilis has quit [Quit: bye]
15:46imobilis has joined #asahi
16:00mikewilks[m] has quit [Quit: Idle for 30+ days]
16:18nondi_ocesan[m] has joined #asahi
16:23Tokamak has joined #asahi
16:30danilonc has quit [Quit: WeeChat 1.9.1]
16:31danilonc has joined #asahi
16:31danilonc has joined #asahi
16:31danilonc has quit [Changing host]
16:31danilonc has quit [Client Quit]
16:32danilonc has joined #asahi
16:35danilonc has quit [Client Quit]
16:36danilonc has joined #asahi
16:36danilonc has quit [Client Quit]
16:37danilonc has joined #asahi
16:48danilonc has quit [Disconnected by services]
16:49danilonc_ has joined #asahi
16:53danilonc has joined #asahi
16:53danilonc_ has quit [Client Quit]
17:20awordnot has joined #asahi
17:27kettenis has quit [Quit: leaving]
17:29kettenis has joined #asahi
17:29mndza has quit [Read error: Connection reset by peer]
17:30mndza has joined #asahi
17:31hir0 has quit [Quit: hir0]
17:38VinDuv has joined #asahi
18:19mps has joined #asahi
18:26kido has quit [Changing host]
18:26kido has joined #asahi
18:35hir0 has joined #asahi
18:48brandas has joined #asahi
18:52brandas_ has quit [Ping timeout: 264 seconds]
18:55roxfan2 is now known as roxfan
19:23Bublik has quit [Ping timeout: 272 seconds]
19:25Bublik has joined #asahi
19:38raster has quit [Quit: Gettin' stinky!]
20:08hir0 has quit [Quit: hir0]
20:54leah2 has quit [Ping timeout: 260 seconds]
20:55leah2 has joined #asahi
21:10kettenis has quit [Quit: leaving]
21:10brandas has quit [Quit: quit]
21:11brandas has joined #asahi
21:22raster has joined #asahi
21:26mndza has quit [Ping timeout: 256 seconds]
21:54raster has quit [Quit: Gettin' stinky!]
21:58VinDuv has quit [Quit: Leaving.]
22:29amw has joined #asahi
22:41austriancoder has quit [Read error: Connection reset by peer]
22:41austriancoder has joined #asahi
23:37jamadazi has joined #asahi
23:37kettenis has joined #asahi
23:47linkmauve has quit [Ping timeout: 256 seconds]
23:49jamadazi has quit [Read error: Connection reset by peer]
23:56kettenisjust pushed changes to make the serial port work in u-boot
…