#
…

2025-02-08

00:00chadmed has joined #asahi-dev
00:00chrisl has joined #asahi-dev
00:07emilia-miki has joined #asahi-dev
00:08chrisl has quit [Ping timeout: 480 seconds]
00:27HitokiriKincho has joined #asahi-dev
00:28yuyichao_ has quit [Ping timeout: 480 seconds]
00:31Extern has joined #asahi-dev
00:31Extern has quit []
00:33HitokiriKincho has quit [Quit: Leaving...]
00:35Extern has joined #asahi-dev
00:48Extern has quit [Quit: WeeChat 4.1.1]
00:52sudtho has joined #asahi-dev
01:00sudtho has quit [Ping timeout: 480 seconds]
01:02pb17 has quit [Ping timeout: 480 seconds]
01:29pb17 has joined #asahi-dev
01:54chadmedis there any point to writing wrappers for some of these adt routines that are only ever called internally?
01:55chrisl has joined #asahi-dev
01:57emilia-miki has quit [Quit: emilia-miki]
02:03chrisl has quit [Ping timeout: 480 seconds]
02:05HitokiriKincho has joined #asahi-dev
02:11chrisl has joined #asahi-dev
02:20chrisl has quit [Ping timeout: 480 seconds]
02:40pb17 has quit [Ping timeout: 480 seconds]
02:41HitokiriKincho has quit [Remote host closed the connection]
02:42HitokiriKincho has joined #asahi-dev
02:42pb17 has joined #asahi-dev
02:48Halian has quit [Quit: I'll be back.]
02:50Halian has joined #asahi-dev
02:50HitokiriKincho has quit [Ping timeout: 480 seconds]
03:13HitokiriKincho has joined #asahi-dev
03:15john-cabaj has joined #asahi-dev
03:21HitokiriKincho has quit [Ping timeout: 480 seconds]
03:25john-cabaj has quit [Ping timeout: 480 seconds]
03:38HitokiriKincho has joined #asahi-dev
03:49tobhe_ has joined #asahi-dev
03:56tobhe has quit [Ping timeout: 480 seconds]
03:58chadmed has quit [Quit: Konversation terminated!]
03:58chadmed has joined #asahi-dev
04:00pb17 has quit [Ping timeout: 480 seconds]
04:14chadmed has quit [Quit: Konversation terminated!]
04:14chadmed has joined #asahi-dev
04:21nora_ has joined #asahi-dev
04:23nora has quit [Ping timeout: 480 seconds]
04:28ddxtanx has quit [Remote host closed the connection]
04:28pb17 has joined #asahi-dev
04:31chadmed has quit [Read error: No route to host]
04:31chadmed has joined #asahi-dev
05:11chrisl has joined #asahi-dev
05:13duckworld has quit [Remote host closed the connection]
05:18duckworld has joined #asahi-dev
05:18JayBeeFOSS has quit [Remote host closed the connection]
05:19duckworld has quit [Remote host closed the connection]
05:20chrisl has quit [Ping timeout: 480 seconds]
05:20duckworld has joined #asahi-dev
05:20JayBeeFOSS has joined #asahi-dev
05:34BesterGester has quit [Quit: The Lounge - https://thelounge.chat]
05:38checkfoc_us9 has quit []
05:41checkfoc_us9 has joined #asahi-dev
06:07pb17 has quit [Ping timeout: 480 seconds]
06:17chrisl has joined #asahi-dev
06:22pb17 has joined #asahi-dev
06:26chrisl has quit [Ping timeout: 480 seconds]
06:28Leo3418 has quit [Quit: Applying updates]
06:28pjakobsson_ has joined #asahi-dev
06:28Leo3418 has joined #asahi-dev
06:31crabbedhaloablution has quit []
06:32pjakobsson has quit [Ping timeout: 480 seconds]
06:32crabbedhaloablution has joined #asahi-dev
06:54darkapex has quit [Ping timeout: 480 seconds]
06:54darkapex has joined #asahi-dev
07:05duckworld has quit [Remote host closed the connection]
07:06duckworld has joined #asahi-dev
07:09iyes has joined #asahi-dev
07:09HitokiriKincho has quit [Remote host closed the connection]
07:10HitokiriKincho has joined #asahi-dev
07:12HitokiriKincho has quit [Remote host closed the connection]
07:12HitokiriKincho has joined #asahi-dev
07:26chrisl has joined #asahi-dev
07:27ddxtanx has joined #asahi-dev
07:28chadmedthe last bindings i did were glib<->Lua so this is kinda alien
07:34chrisl has quit [Ping timeout: 480 seconds]
07:45pb17 has quit [Ping timeout: 480 seconds]
07:54mildsunrise has quit [Quit: disconnect]
07:55mildsunrise has joined #asahi-dev
08:00chadmedone thing im not too sure on is the ADT_MAX_SIZE stuff. surely theres a way we can get the actual adt size. how does the dumper know where to stop?
08:02chadmedoh its in the boot args
08:05pb17 has joined #asahi-dev
08:10lena6 has joined #asahi-dev
08:15j`eywhats with check_header() using 0 as *const ADTNodeHeader>
08:15Halian has quit [Quit: I'll be back.]
08:16j`eyyou can also use prop.is_null() instead of casting to a number and == 0
08:18j`eycheck_offset could return a Result<>. then you'd write: ret = ADT::check_offset(offset)?;
08:20chadmedj`ey: the adt header is just a "normal" node at the base address given to us by iboot
08:20chadmedits using 0 as the offset argument into check_node
08:21chadmedoh wait what lmfao i cast it
08:21j`eyyes you just pass 0 as a ptr and check_node() derefs that!
08:22chadmedi rewrote check_node to play nicer with everything else and didnt change check_header :p
08:23chadmedfixed, thanks
08:27j`eydata field isnt used yet, I guess because you never look into it itself, since youre using bindings
08:28chadmedyeah. to rewrite all the logic Properly(tm) we also need the boot args, and i cant figure out how lina did the agx struct versioning magic
08:29chadmedand i feel like given she _can_ do that, doing it the old fashioned way is just a waste of time
08:29j`eythis probably doesn't need all that?
08:30chadmedcan we just grab the device tree size from the c land boot args
08:30j`eyyou can just write a C function and add a binding, if its easier
08:31chadmedoh yeah...
08:31j`ey(to return the adt size)
08:50gladiac has joined #asahi-dev
09:16lena6 has quit [Remote host closed the connection]
09:17chrisl has joined #asahi-dev
09:25chrisl has quit [Ping timeout: 480 seconds]
09:29tanty has quit [Ping timeout: 480 seconds]
09:29BesterGester has joined #asahi-dev
10:00opticron has quit [Read error: Connection reset by peer]
10:00opticron has joined #asahi-dev
10:00HitokiriKincho has quit [Remote host closed the connection]
10:01iyes has quit [Ping timeout: 480 seconds]
10:01HitokiriKincho has joined #asahi-dev
10:04iyes has joined #asahi-dev
10:14chrisl has joined #asahi-dev
10:18tanty has joined #asahi-dev
10:22chrisl has quit [Ping timeout: 480 seconds]
10:31HitokiriKincho has quit [Remote host closed the connection]
10:32chadmed has quit [Quit: Konversation terminated!]
10:32HitokiriKincho has joined #asahi-dev
10:32HitokiriKincho has quit [Remote host closed the connection]
10:33HitokiriKincho has joined #asahi-dev
10:33chadmed has joined #asahi-dev
10:34chadmed\o/ from m1n1 with a bunch of adt logic rewritten in rust (we love testing in prod)
10:34sveneveryone tests in prod, some people are just lucky enough to also have a test environment ;)
10:35chadmedwe have testers, theyre called users
10:36chaos_princessthe best part is when you supposedly have an independent "test" environment, and after you push a release to there, you somehow break prod :P
10:36chaos_princesswhy adt btw, it is not an untrusted input, no?
10:37j`eygotta start somewhere
10:38chadmedi was going to start with the display config stuff that broke recently but everything is so entangled, and from quick vibe analysis it seems like ADT lives somewhere near the middle of that entanglement
10:39chaos_princessmakes sense then
10:40chadmedit also seemed a little easier than other parts of m1n1 that have more moving parts, and ive never done this before :)
10:41chadmedit would be good to get rid of some of the #![feature] stuff too
10:59dcavalca8569 has quit [Ping timeout: 480 seconds]
11:05dcavalca8569 has joined #asahi-dev
11:07chadmedokay ive cleaned up the commits and have a working branch here https://github.com/chadmed/m1n1/commits/riir/adt/
11:10pb17 has quit [Ping timeout: 480 seconds]
11:14iyes has quit [Ping timeout: 480 seconds]
11:20chadmed has quit [Quit: Konversation terminated!]
11:21chrisl has joined #asahi-dev
11:29chrisl has quit [Ping timeout: 480 seconds]
11:35HitokiriKincho has quit [Remote host closed the connection]
11:36HitokiriKincho has joined #asahi-dev
11:38chadmed has joined #asahi-dev
11:44HitokiriKincho has quit [Ping timeout: 480 seconds]
11:51sand4rt has joined #asahi-dev
11:57pb17 has joined #asahi-dev
11:58johey_ has joined #asahi-dev
11:59sand4rt has quit [Ping timeout: 480 seconds]
12:00johey has quit [Ping timeout: 480 seconds]
12:19sting has quit [Quit: doei]
12:27chrisl has joined #asahi-dev
12:27sting has joined #asahi-dev
12:29svennickchan: can you link me to your pending patch series that have to go through asahi-soc that are still pending?
12:35chrisl has quit [Ping timeout: 480 seconds]
12:44patrickm has quit [Ping timeout: 480 seconds]
12:48HitokiriKincho has joined #asahi-dev
12:52patrickm has joined #asahi-dev
12:58lucyllewy has quit [Quit: Connection closed for inactivity]
13:22pb17 has quit [Ping timeout: 480 seconds]
13:33pb17 has joined #asahi-dev
13:34nepeat_ has joined #asahi-dev
13:39nepeat has quit [Ping timeout: 480 seconds]
13:51chrisl has joined #asahi-dev
13:54HitokiriKincho has quit [Ping timeout: 480 seconds]
13:59chrisl has quit [Ping timeout: 480 seconds]
14:04HitokiriKincho has joined #asahi-dev
14:08svenarnd: do you also need a PR for the updates to MAINTAINERS or are they going to be picked up directly since they were sent to soc@lists.linux.dev?
14:13arndsven: the patch to soc@ is sufficient, you can see it's in patchwork at https://patchwork.kernel.org/project/linux-soc/list/ so I will pick it up from there
14:14HitokiriKincho has quit [Ping timeout: 480 seconds]
14:16arndin general, patches and pull requests sent to soc@lists.linux.dev are equivalent for simple changes, while for any larger series a pull request is nicer because it gives you the chance to have a summary for the merge commit that gets preserved in the git history, and you can be sure I get the exact same commit IDs that you have tested
14:16arndfor the maintainer file update, neither of those is important
14:17arndI usually pick up updates to MAINTAINERS in the bugfix branch since it helps to have the latest version in the release, and there is no regression risk
14:19arndI might change the subject line to s/myself/Janne/ since that makes more sense for the shortlog
14:23HitokiriKincho has joined #asahi-dev
14:23svenmakes sense, thanks!
14:27johey_ has quit [Ping timeout: 480 seconds]
14:29chrisl has joined #asahi-dev
14:36sand4rt has joined #asahi-dev
14:37chrisl has quit [Ping timeout: 480 seconds]
14:42johey has joined #asahi-dev
14:46HitokiriKincho has quit [Ping timeout: 480 seconds]
14:46patrickm has quit [Ping timeout: 480 seconds]
14:54patrickm has joined #asahi-dev
14:54HitokiriKincho has joined #asahi-dev
15:04HitokiriKincho has quit [Ping timeout: 480 seconds]
15:34chrisl has joined #asahi-dev
15:36pb17 has quit [Ping timeout: 480 seconds]
15:42chrisl has quit [Ping timeout: 480 seconds]
16:04pb17 has joined #asahi-dev
16:19HitokiriKincho has joined #asahi-dev
16:23patrickm has quit [Ping timeout: 480 seconds]
16:27HitokiriKincho has quit [Ping timeout: 480 seconds]
16:29patrickm has joined #asahi-dev
16:30nimprod3l has joined #asahi-dev
16:33nimprod3l has quit []
16:37Extern has joined #asahi-dev
16:48chrisl has joined #asahi-dev
16:51sand4rt has quit [Ping timeout: 480 seconds]
16:51HitokiriKincho has joined #asahi-dev
16:56chrisl has quit [Ping timeout: 480 seconds]
16:59HitokiriKincho has quit [Ping timeout: 480 seconds]
17:07patrickm has quit [Remote host closed the connection]
17:08patrickm has joined #asahi-dev
17:09HitokiriKincho has joined #asahi-dev
17:16patrickm has quit [Remote host closed the connection]
17:18patrickm has joined #asahi-dev
17:27nickchansven: 3 serieses and a singular patch, in order,
17:30nickchan3 and 4 conflicts with each other however because they add completely unrelated things to the same part of the .dts file (keep both is the resolution)
17:31nickchansven: This is how I would resolve and apply the patches straight from the ML https://github.com/asdfugil/linux-apple/tree/ddbf3a964ef57b6da1149868235cf0574bcda2f6
17:42nicolas17nickchan: A9 variants even use different files for iOS OTA updates
17:43nicolas17appledb had to change the json schema to deal with that ._.
17:46chrisl has joined #asahi-dev
17:49svennickchan: thx, will take a look tomorrow. if they are have reviews/ack i'll pull them in
17:54chrisl has quit [Ping timeout: 480 seconds]
17:56nicolas17"The modesetting driver does not check the non-desktop connector property and keeps the device open and locked. If the touchbar daemon opens the device first modesetting breaks the whole X session. Simply refuse to open the device for X11 server processes as workaround." ew :(
17:56nickchansven: Everything outside of arch/arm64/boot/dts/apple (the bindings) have acks from krzk, as for the actual .dts files however, only the PMGR ones have some acks, excluding "arm64: dts: apple: t8012: Add PMGR nodes"
17:59nickchanall of them are at least a month old without objections however
18:12Extern has quit [Quit: WeeChat 4.1.1]
18:15chrisl has joined #asahi-dev
18:16HitokiriKincho has quit [Ping timeout: 480 seconds]
18:27chrisl has quit [Ping timeout: 480 seconds]
18:34HitokiriKincho has joined #asahi-dev
18:43HitokiriKincho has quit [Ping timeout: 480 seconds]
18:49yuyichao_ has joined #asahi-dev
18:59chrisl has joined #asahi-dev
19:07chrisl has quit [Ping timeout: 480 seconds]
19:29svenok, I’ll take a look tomorrow then
19:31chrisl has joined #asahi-dev
19:40chrisl has quit [Ping timeout: 480 seconds]
19:52HitokiriKincho has joined #asahi-dev
20:00pb17 has quit [Ping timeout: 480 seconds]
20:01HitokiriKincho has quit [Ping timeout: 480 seconds]
20:06parazyd has quit [Quit: -YES]
20:21pb17 has joined #asahi-dev
20:33chrisl has joined #asahi-dev
20:41chrisl has quit [Ping timeout: 480 seconds]
21:03commandoline has quit [Quit: Bye!]
21:04commandoline has joined #asahi-dev
21:04commandoline has quit []
21:07commandoline has joined #asahi-dev
21:10sativa93 has joined #asahi-dev
21:10HitokiriKincho has joined #asahi-dev
21:18emilia-miki has joined #asahi-dev
21:18HitokiriKincho has quit [Ping timeout: 480 seconds]
21:18sativa93 has quit [Ping timeout: 480 seconds]
21:31pb17 has quit [Ping timeout: 480 seconds]
21:32sativa93 has joined #asahi-dev
21:33chrisl has joined #asahi-dev
21:34sativa93 has quit [Remote host closed the connection]
21:36sativa93 has joined #asahi-dev
21:37sativa93 has quit []
21:37sativa93 has joined #asahi-dev
21:41chrisl has quit [Ping timeout: 480 seconds]
21:42emilia-miki has quit [Ping timeout: 480 seconds]
21:49lena6 has joined #asahi-dev
21:57HitokiriKincho has joined #asahi-dev
21:58pb17 has joined #asahi-dev
22:06HitokiriKincho has quit [Ping timeout: 480 seconds]
22:07sativa93 has quit [Quit: Textual IRC Client: www.textualapp.com]
22:15HitokiriKincho has joined #asahi-dev
22:20chrisl has joined #asahi-dev
22:34chrisl has quit [Ping timeout: 480 seconds]
23:05HitokiriKincho has quit [Ping timeout: 480 seconds]
23:15chrisl has joined #asahi-dev
23:23chrisl has quit [Ping timeout: 480 seconds]
23:37pb17 has quit [Ping timeout: 480 seconds]
23:44lena6 has quit [Remote host closed the connection]
23:46ddxtanx has quit [Remote host closed the connection]
23:49ddxtanx has joined #asahi-dev
23:56pb17 has joined #asahi-dev
23:57HitokiriKincho has joined #asahi-dev
…