2023-08-14
00:04Method has joined #asahi-dev
00:10ntl has joined #asahi-dev
00:11ntl is now known as NathanLadd
00:41NathanLadd has quit [Remote host closed the connection]
00:52cylm_ has quit [Ping timeout: 480 seconds]
01:14___nick___ has joined #asahi-dev
01:14___nick___ has quit []
01:17___nick___ has joined #asahi-dev
01:22rootbeerdan has quit [Quit: rootbeerdan]
02:00gabuscus has quit []
02:08jeisom has quit [Quit: Leaving]
02:32gabuscus has joined #asahi-dev
02:35utsweetyfish has quit [Remote host closed the connection]
02:35utsweetyfish has joined #asahi-dev
02:38ciara has joined #asahi-dev
02:43ciara has quit [Read error: Connection reset by peer]
02:44pbsds has quit [Quit: The Lounge - https://thelounge.chat]
02:45pbsds has joined #asahi-dev
02:45ciara has joined #asahi-dev
02:50utsweetyfish has quit [Remote host closed the connection]
02:51utsweetyfish has joined #asahi-dev
02:54ciara has quit [Quit: Leaving]
03:12crabbedhaloablut has joined #asahi-dev
03:23bisko has quit [Ping timeout: 480 seconds]
03:31ciara has joined #asahi-dev
03:31NathanLadd has joined #asahi-dev
03:37ciara has quit [Read error: Connection reset by peer]
03:43utsweetyfish has quit [Remote host closed the connection]
03:45ciara has joined #asahi-dev
03:48utsweetyfish has joined #asahi-dev
03:54NathanLadd has quit [Ping timeout: 480 seconds]
04:10utsweetyfish has quit [Remote host closed the connection]
04:10utsweetyfish has joined #asahi-dev
04:14NathanLadd has joined #asahi-dev
04:20spuos has quit [Remote host closed the connection]
04:23NathanLadd has quit [Ping timeout: 480 seconds]
04:25psykose has quit [Remote host closed the connection]
04:26psykose has joined #asahi-dev
05:08utsweetyfish has quit [Remote host closed the connection]
05:10utsweetyfish has joined #asahi-dev
05:50novafacing99 has quit [Ping timeout: 480 seconds]
05:59cylm_ has joined #asahi-dev
06:23utsweetyfish has quit [Remote host closed the connection]
06:25utsweetyfish has joined #asahi-dev
06:34ellyq has quit [Read error: No route to host]
07:15timokrgr has quit [Quit: User left the chat]
07:17timokrgr has joined #asahi-dev
08:04jacksonchen666 has quit [Quit: WeeChat 3.8]
08:26eiln has joined #asahi-dev
08:31leitao has joined #asahi-dev
09:23nst has quit [Quit: WeeChat 3.8]
09:35eilnI'll just patch adt to match the sio struct. I have to add another range for the firmware heap anyway
09:45nst has joined #asahi-dev
10:28chadmedok so final piece of the puzzle for the speakers is going to be _somehow_ convincing pipewire to tie the volume knob of a sink to a parameter in a filter chain
10:29chadmedif we can make pipewire present the volume knob of the lsp equal loudness plugin as _the_ volume then we're home free
10:30chadmedthat popping noise is back and i think its just a limitation of the codecs that we have to work around by making the speakers sound good at full volume and then using the equal loudness plugin to maintain a consistent profile when the user turns the volume down
10:34dsharshakov has joined #asahi-dev
10:35dsharshakovchadmed: could you please open a new issue for that? It'd be more convenient to discuss implementation details there
10:36dsharshakovthat should go to pipewire/pipewire, not WP
10:50nst has quit [Ping timeout: 480 seconds]
11:00nst has joined #asahi-dev
11:01dsharshakov has quit [Quit: Page closed]
11:06jeisom has joined #asahi-dev
11:12chadmedpovik: its not overexcursion, it sounds almost like clipping artefacts but the signal is nowhere near being saturated
11:12chadmedits ~the same pop/click that is audible when you abrubptly mute/pause a stream sometimes, but much louder
11:17povikhow does making it sound good at full volume work around the clicks if we don't know what causes them?
11:17jeisom has quit [Quit: Leaving]
11:21povikhttps://github.com/AsahiLinux/linux/blob/sound/ivsense-improvements/sound/soc/codecs/tas2764-quirks.h
11:22povikyou either need to supply it at boot, or you can change it at runtime then use the reset_codecs.sh script from macaudio-userutils
11:24chadmedpovik: we tune at full volume such that the clicks do not happen (this is possible ive already tried it) then use the equal loudness plugin to keep that sonic profile across the volume range
11:24chadmedi mocked this up in carla so i know it can be done, and is what youd usually do. everything ive been doing lately has been desperately trying to work around this because we cant control the loudness compensator at runtime
11:25chadmedbut hopefully we can find a way forward: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3434 (cc dsharshakov)
11:28poviki would understand if the popping noise was introduced in some processing stage that you would work around it by rearranging the graph
11:28povikbut if the popping is introduced in the codecs what can you do in the processing to work around it?
11:30chadmedwhat im doing atm is driving the bass "enhancement" harder than it neds to be driven so that it sounds right at normal volumes
11:31chadmedwhich is why im pretty sure its just digital clipping inside the codecs once the volume going in goes up past a certain amount
11:31chadmedif i tune the graph (bass enhancement, compressor, etc) for sounding "right" at max volume then none of this matters
11:33chadmedthe part im kind of at a loss to explain is that if i push the volume *past* where this noise becomes audible, it goes away for a bit until i push hard enough to get overexcursion
11:33povikso if you tune it to sound "right" at max volume, the bass would be attenuated at normal volumes?
11:34chadmedyeah, without equal loudness compensation you get aggressive rolloff in the bass and treble
11:34chadmedbit of an unfortunate double-whammy with where the human ear's sensitivity peaks and how these speakers behave
11:34povikok, but if you introduce the equal loudness compensation, wouldn't you effectively get what you started out with, that caused the clipping noise?
11:34chadmedno because the equal loudness compensation would do nothing at max volume, and then do its compensation as we turn the volume down
11:35chadmedit just pulls the mids down faster than it does treble and bass, based on iso 226:2003 curves
11:36povikso the change here is that you don't enhance the basses as hard at max volume, if you tune it differently and introduce the equal loudness compensation, is that right?
11:37chadmedin fact it was one of the first things i did under the assumption that the loudness compensator could be controlled from pipewire
11:37jeisom has joined #asahi-dev
11:39chadmedyeah sorry its hard to really explain unless youre actually in front of the thing and can hear whats going on
11:39chadmeddoesnt help that using loudness compensation like this is not the "traditional" way youd use it :P
11:40chadmedbut its what apple does and seemingly every other microspeaker engineer on earth now so *shrug*
11:48c10l has quit [Ping timeout: 480 seconds]
11:52c10l has joined #asahi-dev
12:41ciara has quit [Read error: No route to host]
12:43ciara has joined #asahi-dev
13:10jeisom has quit [Quit: Leaving]
14:04eilnpovik: filters are identical as macos. it still looks good, but I guess that wasn't enough for them
14:14bisko has joined #asahi-dev
14:30jeisom has joined #asahi-dev
14:50jeisom has quit [Ping timeout: 480 seconds]
14:56marcaneiln: no need for that, software postpro is out of scope for the driver and kinda overkill right now (unlike the speakers where you really really really need DSP for it to be usable at all)
14:57marcanif someone is bored I'm sure there's fun stuff to be done with PipeWire, but it's completely optional
15:10NathanLadd has joined #asahi-dev
15:13iyes has joined #asahi-dev
15:13NathanLadd has quit []
15:26Z750 has quit [Quit: Ping timeout (120 seconds)]
15:28Z750 has joined #asahi-dev
15:33Z750 has quit []
15:36Z750 has joined #asahi-dev
15:49Z750 has quit [Quit: Ping timeout (120 seconds)]
15:49Z750 has joined #asahi-dev
15:51cylm_ has quit [Ping timeout: 480 seconds]
16:01iyes has quit [Quit: This computer has gone to sleep]
16:42rhysmdnz has quit [Quit: Bridge terminating on SIGTERM]
16:42Guest8625 has quit [Quit: Bridge terminating on SIGTERM]
16:46Jamie has joined #asahi-dev
16:46Jamie is now known as Guest8880
16:47rhysmdnz has joined #asahi-dev
17:08MortimerHoughton has joined #asahi-dev
17:09iyes has joined #asahi-dev
17:24MortimerHoughton has quit [Quit: leaving]
17:33dsharshakov has joined #asahi-dev
17:35iyes has quit [Quit: This computer has gone to sleep]
17:37dsharshakovchadmed: :bell: you've got a message in #pipewire. Is it possible to use mb_compressor_mono in place of stereo one because stereo doesn't have separate channel volumes? If so, won't it hog performance a lot bc of extra plugin instance?
17:38dsharshakovre PipeWire and ISP: if any processing suitable for userspace is necessary, feel free to play around with libcamera. However, if ISP's model can be integrated into v4l2, there should be at least minimal function set with v4l2
17:40dsharshakovwith libcamera you can integrate a webcam with your own kernel interface into PW. The problem why it's not the sole method is that not all apps work fine with v4l2 - pw adapter lib
17:40dsharshakov has quit [Quit: Page closed]
17:52midou has quit [Ping timeout: 480 seconds]
17:55iyes has joined #asahi-dev
17:55iyes has quit []
17:57midou has joined #asahi-dev
17:57ciara has quit [Read error: Connection reset by peer]
17:59ciara has joined #asahi-dev
18:28leitao has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:47ntl has joined #asahi-dev
18:47ntl is now known as NathanLadd
19:07dsharshakov has joined #asahi-dev
19:09dsharshakoveiln: did you manage to solve the multiple-buffer issue? If so, you likely don't really need libcamera path as v4l2 works fine. Probably ISP does most stuff itself and driver doesn't have to do any processing thus kernel-only impl is fine
19:13ciara has quit [Read error: Connection reset by peer]
19:16ciara has joined #asahi-dev
19:20sam_ is now known as Guest8894
19:21Guest8894 has quit [Remote host closed the connection]
19:22sam_ has joined #asahi-dev
19:25eilndsharshakov: I did figure it out, thanks to everyone here, but I actually bruteforced CISP_CMD_CH_BUFFER_POOL_CONFIG_GET to disable that (now I'm really sorry for that wall of text, whoops). the new permutation of config vals also lets me send the (required per-frame) meta buffer with the frames, so that's half the number of irqs needed & ensures frames are never dropped bc the
19:25eilnframe/meta count is off. I believe macos' weird batching scheme was bc of the face detection prediction mask, which effs up the cadence.
19:26dsharshakovwell, likely you'll manage to do it without complex kernel-userspace pairing with libcamera. V4L2 is better is terms of compatibility and versatility right now
19:27roxfan has joined #asahi-dev
19:31ciara has quit [Read error: Connection reset by peer]
19:36dsharshakov has quit [Quit: Page closed]
19:37WindowPa- has joined #asahi-dev
19:42WindowPain has quit [Ping timeout: 480 seconds]
19:45eiln has quit [Quit: WeeChat 4.0.3]
19:59jeisom has joined #asahi-dev
20:08___nick___ has quit [Ping timeout: 480 seconds]
20:42crabbedhaloablut has quit []
20:48ciara has joined #asahi-dev
21:08chadmed has quit [Remote host closed the connection]
21:11NathanLadd has quit [Ping timeout: 480 seconds]
22:24NathanLadd has joined #asahi-dev
22:38pthariensflame has joined #asahi-dev
22:39pthariensflame has quit []
22:42darkapex has quit [Remote host closed the connection]
22:42darkapex has joined #asahi-dev
22:43cy8aer has joined #asahi-dev
23:20ourdumbfuture_ has quit [Quit: My Mac has gone to sleep. ZZZzzz…]
23:22ourdumbfuture has joined #asahi-dev
23:29NathanLadd has quit [Ping timeout: 480 seconds]
23:38WindowPa- has quit [Quit: ZNC 1.8.2 - https://znc.in]
23:40WindowPain has joined #asahi-dev