#
…

2022-09-19

00:25thelounge7571340 has quit [Remote host closed the connection]
00:29thelounge7571340 has joined #asahi-dev
01:28thelounge7571340 has quit [Remote host closed the connection]
01:30thelounge7571340 has joined #asahi-dev
02:30thelounge7571340 has quit [Remote host closed the connection]
02:35thelounge7571340 has joined #asahi-dev
03:13thelounge7571340 has quit [Ping timeout: 480 seconds]
03:42kov has quit [Quit: Coyote finally caught me]
04:13thelounge7571340 has joined #asahi-dev
04:39thelounge7571340 has quit [Remote host closed the connection]
04:43thelounge7571340 has joined #asahi-dev
05:23HendrawanKuncoro[m] has joined #asahi-dev
05:43thelounge7571340 has quit [Read error: Connection reset by peer]
05:47thelounge7571340 has joined #asahi-dev
06:01thelounge7571340 has quit [Ping timeout: 480 seconds]
06:12SSJ_GZ has joined #asahi-dev
06:34jakebot602 has quit [Quit: The Lounge - https://thelounge.chat]
07:02thelounge7571340 has joined #asahi-dev
07:05jakebot602 has joined #asahi-dev
07:21gladiac has joined #asahi-dev
07:22princesszoey has quit [Quit: The Lounge - https://thelounge.chat]
07:23princesszoey has joined #asahi-dev
07:29gladiac has quit [Quit: k thx bye]
07:50MajorBiscuit has joined #asahi-dev
08:01thelounge7571340 has quit [Remote host closed the connection]
08:05jluthra has quit [Remote host closed the connection]
08:05jluthra has joined #asahi-dev
08:07thelounge7571340 has joined #asahi-dev
08:40marcanm1n1 only really directly boots kernels for debugging, so it's not that big a deal, but yeah, I should fix that
09:06thelounge7571340 has quit [Read error: Connection reset by peer]
09:12thelounge7571340 has joined #asahi-dev
10:11thelounge7571340 has quit [Remote host closed the connection]
10:12povikjust to make sure: this ^ has DT patches that should go in for 6.1 for us not to have issues with a shared audio reset
10:12poviksince the binding change has an ack already (it got one within 3m of posting!) patches #1 and #2 should be good to pick up
10:13thelounge7571340 has joined #asahi-dev
10:14chip_x has joined #asahi-dev
10:16chipxxx has quit [Read error: Connection reset by peer]
10:17svenmarcan: fwiw, that command that breaks bluetooth on 6.0-rc6 is somehow related to coex afaict
10:18svenit does some "Mobile Wireless Standard" frame configuration. it's unclear if this also includes wifi though
10:19_jannau_I think it's just mobile phone networks
10:19svencould be, it's a bit unclear
10:19svenit also fails with "command disallowed" and not with "unknown command"
10:21sven" The Bluetooth Core Specification does not specify signalling between the Bluetooth Controller and a Wireless LAN device." so jannau is right, this MWS seems to be about coex with other 2.4 GHz radios
10:21_jannau_so there is need to support it for ipads with cellular network support (and iphones) but using it doesn't make sense on macbooks
10:22svenit's still weird the firmware on 4378/87 claims to support it but then disallows that command though
10:22marcanstill wondering if there's an actual wlan coex enable though, or I'm missing something on the wlan side. changing coex profiles on the wlan side didn't seem to do anything
10:22sven4377 claims support and _does_ support that command
10:22marcanthere is some readback support for the coex stuff, I should try it and see if it's *doing* anything on the wlan side
10:22svenhave you pushed the wifi tracer? i can adapt the bt tracer and make it spit out btmon traces we can stare at then
10:23svenon macos it does lots of vendor specific commands but I can't easily trace the setup there
10:24sventhere's a cute "PacketLogger" thing you can get with xcode. older versions seem to even include names for most vendor commands :D
10:24marcansven: just pushed, have fun
10:25svennice, thanks
10:25marcanSuper_Peek_Poke Super_Duper_Peek_Poke lol
10:25marcanWriteHoppingChannels sounds like it could be related
10:26marcanReadCollaborationMode WriteCollaborationMode also
10:26sventhere are a few suspicious commands
10:26marcanalso WriteHighPriorityConnection
10:26sveni'll try to get the bt tracer to just spit out btmon logs. staring at bluetooth hex commands isn't much fun
10:27marcanCoexBandwidthStatistics is probably receive only but useful
10:27marcanVSC_COEX_WRITE_WIMAX_CONFIGURATION... wimax?
10:27sventhey dumped pretty much all broadcom vendor commands into PacketSniffer afaict
10:28sven(well, all vendor commands that existed a few years ago before they noticed)
10:29marcanReadSupportedVSCs sounds useful
10:29marcanVSC_ForceWLANChannel also
10:29svenI think I tried ReadSupportedVSCs and just got "command denied" or something
10:29svenbut maybe it needs parameters
10:29marcanand VSC_ChangeConnectionPriority could be related to coex prio
10:29marcanVSC_CoExDebugCounters
10:30marcanVSC_ChangeLNAGainCoexECI hmm
10:30marcananyway, yeah, trace macos and see what it does?
10:30svenyup, pretty much
10:32svenjust need to take r's tracer and move it over to the new pcie framework and then make it spit out the commands in a way humans can read them
10:32marcanand make sure to test a coex scenario (A2DP with wifi on 2.4) to see if anything changes
10:32marcanmacos changes the wlan coex profile on 2.4 but not 5, when A2DP starts sending data (when audio plays)
10:32svenoh, interesting
10:33sveni think i can already do that just from macos without the hv.
10:33marcanI think what that does is prioritize l2cap, but I don't know for sure
10:34svenwell, if i can force it to 2.4 GHz without changing my wlan ap config :/
10:35marcanthis is why I have 2.4-only and 5-only SSIDs...
10:37chadmed[m]+1 i have a particularly noisy microwave and band steering only guarantees that my entire network goes down when anyones trying to cook rice
10:37svenit's spamming lots of vendor specific commands
10:38svenVSC_HandleLeMetaVsc1 so someting something LE advertisments
10:39svenand VSC_WriteHighPriorityConnection (sounds supicious), VSC_Olympic (???) and VSC_EnhancedLinkQuelityStats
10:40svenyup, just before it starts sending audio frames it seems to send VSC_WriteHighPriorityConnection
10:44marcanmaybe that's all we need then?
10:45marcanit's possible the wlan side coex profile only prioritizes connections marked as that
10:50marcansven: can we figure this out at the hci layer? might need sniffing packets, something something look for an l2cap PSM 0x19 (I think that's the one)?
10:51marcanof course the real way to do this is with a new API but that would end up needing support all the way to userspace..
10:58svenmaybe, let me first try to actually make btcoex fail because uh.. it seems to work here?
11:07marcanyeah that's the thing
11:07marcanit sort of works
11:08marcanjust not... great
11:08marcanit completely falls over with LDAC devices apparently
11:08marcanbut I still get more glitches and hiccups than expected with SBC
11:08marcantry higher bitrates for more effect
11:08marcan(pavucontrol has profiles)
11:13thelounge7571340 has quit [Remote host closed the connection]
11:31kov has joined #asahi-dev
11:40rmkyay, brcm4378 patches merged :)
11:40chadmed[m]queued for 6.1?
11:41svenohh… WiFi
11:41svenconfusingly the Bluetooth chip is also called 4378 ;)
11:41chadmed[m]Certified Broadcom Moment(tm)
11:41rmkand is probably the same device
11:42svenit’s the same device, just a different pcie function
11:42thelounge7571340 has joined #asahi-dev
11:42rmkthe 4329 and 4330 that SolidRun used on their platforms is the same (except it's SDIO for WiFi and serial for BT)
11:42svenchadmed[m]: don’t get me started…
11:42j`eyrmk: yay! 12 down..
11:43rmk24 to go? :/
11:43j`ey*100+ to go :p
11:43rmkI was meaning for brcmfmac
11:44svenfor these macs Broadcom (or apple) decided to invented a new weird IPC over PCIe protocol for sone reason
11:45chadmed[m]hopefully t6k dart goes in for 6.1 too so we can actually have wifi across the board
11:45jannauI think we have more 200 patches on top of v6.0-rc5
11:45chadmed[m]jannau: im pulling down the whole tree now to recalc this while i have Feature Support open
11:46rmkit would've been nice to get macsmc gpio and pcie sorted so we could have the wifi functional for 6.1
11:46jannaustill no email/commit from Joerg since sunday morning a week ago
11:47rmkbut at least we have some progress towards macsmc gpio
11:47j`ey$ git rev-list v6.0-rc5..asahi-6.0-rc5-4 | wc -l
11:48chadmed[m]"This number should decrease with each new kernel version, major hardware
11:48chadmed[m]changes notwithstanding."
11:48chadmed[m]this sentence didnt even last one kernel release lmaoo
11:48rmkj`ey: so my efforts will have knocked off about 15 patches from that, but I bet by 6.1-rc1 there'll be more than 15 new patches added
11:48svengetting Bluetooth into 6.2 might be pushing it but I’ll try to send out v3 this evening
11:50j`eyrmk: dont think of it like that, still progress ;)
11:51svenAnd like 50 of those patches are relatively boring dts updates anyway
11:53j`eysven: what are you doing with bt and that GetMWSConfig thing
11:53svenadd a quirk
11:54svenit’s just that one command, everything else reported in that get local feature thing seems to work
12:41thelounge7571340 has quit [Remote host closed the connection]
12:52bisko has joined #asahi-dev
13:23thelounge7571340 has joined #asahi-dev
14:03chip_x has quit [Read error: No route to host]
14:22thelounge7571340 has quit [Remote host closed the connection]
14:29thelounge7571340 has joined #asahi-dev
15:28thelounge7571340 has quit [Read error: Connection reset by peer]
15:35thelounge7571340 has joined #asahi-dev
15:38dottedmagchadmed[m]: Well, you threw in "should", right?
16:03sven*here's
16:11bisko has quit [Quit: Textual IRC Client: www.textualapp.com]
16:15svenargh... I miscounted bits. should've been MWS Transport Layer config instead of MWS Pattern config
16:15svenat least this time I noticed before send-email
16:16j`eysven: yay, good luck!
16:34thelounge7571340 has quit [Remote host closed the connection]
16:36thelounge7571340 has joined #asahi-dev
16:38MajorBiscuit has quit [Ping timeout: 480 seconds]
16:53jannaucover latter still mentions "MWS Pattern Configuration" twice
16:53j`eythe .. yeah
16:53svenoh well
16:54svenyeah, I just copied the old cover letter completely
16:56povik\o/ v3 out
16:57svenI wonder if I actually get comments on the actual driver this time :D
16:59marcanrmk: pcie gpio probably won't go into 6.1 because that binding has to change radically, and I can't know I did that right until sleep works
17:00marcanwould've loved to get to this earlier but alas... my schedule has been kind of swamped lately (see Akademy talk tweet, and others) :(
17:00marcanupstreaming is good, but best not rush things that aren't ready, and that one isn't :) (in a way that has compat implications)
17:01marcanre new patches, we'll see, there's the whole sleep thing, but that's a big yak to shave anyway...
17:02marcanI should submit dockchannel, since it looks like that works and it's worth getting in, but it has some deps on the spi-hid series... that whole input stuff needs cleanup and debugging still
17:06rmkmarcan: you mean gpio-macsmc ?
17:07marcanno, I mean the PCIe power GPIO binding/support
17:10jannauI started working on spihid but there is quite a bit of cleanup to do
17:12jannauon input side the keyboard is mostly good to go but we need to decide on dt binding for the keyboard layout
17:14jannauwe need it for hid-apple since we need to set iso_layout dependent on the actual layout and not just the us/iso/jis type
17:16jannaufor hid-magicmouse it would make sense to check if it can't be refactored to share more code between the trackpad and the usb devices
17:16jannauit currently feels a little like two drivers in one file
17:19jannaunot sure where the bad crc packets are coming from but apparently those are not garbled keyboard packets
17:36thelounge7571340 has quit [Remote host closed the connection]
17:43thelounge7571340 has joined #asahi-dev
18:08nicolas17 has joined #asahi-dev
18:09marcanthe keyboard layout is going to be a big yak to shave if we intend to specify all the details
18:11marcando we really need that? afaik Apple's USB stuff does not report anything other than us/iso/jis either
18:11marcanthat's what I did for dockchannel too
18:13marcanI do want us to specify the keyboard layout a different way, but that's a much bigger conversation to be had regarding what the list of valid keyboard types should be
18:13TramtristI was able to configure my Japanese keyboard very easily.. Thank you all again for your good work
18:18ChaosPrincessnot exactly asahi related, but how did y'all started upstreaming patches to kernel. i ported some drivers for an unrelated board from vendors random fork to upstream kernels, and want to upstream it, but want to hear about how people did it
18:18jannauI think it's also a problem for the usb keyboards hence the module option. probably nothing to be done for USB keyboards but we have the information to handle this correctly
18:20jannauwe do not need the full layout in the dt for this. a flag to tell the two iso variants apart would be enough
18:25j`eyChaosPrincess: you just send them out!
18:29jannaumaybe it's just enough to set apple_find_translation
18:29jannauerr, APPLE_ISO_TILDE_QUIRK
18:43thelounge7571340 has quit [Remote host closed the connection]
18:45thelounge7571340 has joined #asahi-dev
18:54sven(and then changed email providers because email sucks *sigh*)
18:55ChaosPrincessi also read all of that, but sending patches that way feels way more intimidating than sending a PR for some reason :P
18:57svensending a PR via email was even more intimidating. I think I sent that nvme PR ti myself like five times before I was convinced everything was good ;)
18:57svenseriously though, just try send-email and see what happens. There’s a very high chance you find some typo or similar mistake 5 seconds later anyway
18:58sven(see my Bluetooth series from a few hours ago…)
19:44thelounge7571340 has quit [Remote host closed the connection]
19:48thelounge7571340 has joined #asahi-dev
20:00compassion has joined #asahi-dev
20:12thelounge7571340 has quit [Ping timeout: 480 seconds]
21:14thelounge7571340 has joined #asahi-dev
21:21chadmed has quit [Ping timeout: 480 seconds]
21:21chadmed has joined #asahi-dev
21:31SSJ_GZ has quit [Ping timeout: 480 seconds]
22:13thelounge7571340 has quit [Remote host closed the connection]
22:17thelounge7571340 has joined #asahi-dev
22:29thelounge7571340 has quit [Ping timeout: 480 seconds]
23:07jole has quit [Ping timeout: 480 seconds]
23:12roxfan has quit [Remote host closed the connection]
23:17roxfan has joined #asahi-dev
23:30thelounge7571340 has joined #asahi-dev
23:37kilolima has joined #asahi-dev
…