#
…

2022-06-11

01:00DragoonAethis has quit [Quit: hej-hej!]
01:00DragoonAethis has joined #asahi-dev
01:09amarioguy has joined #asahi-dev
01:20Emantor has quit [Quit: ZNC - http://znc.in]
01:20Emantor has joined #asahi-dev
01:22derzahl has quit [Ping timeout: 480 seconds]
01:41derzahl has joined #asahi-dev
02:14chadmed has quit [Ping timeout: 480 seconds]
02:41PhilippvK has quit [Ping timeout: 480 seconds]
03:25pyropeter3 has joined #asahi-dev
03:27pyropeter2 has quit [Ping timeout: 480 seconds]
03:46chadmed has joined #asahi-dev
03:47kov has quit [Quit: Coyote finally caught me]
05:12jluthra has quit [Remote host closed the connection]
05:13jluthra has joined #asahi-dev
05:14the_lanetly_052___ has joined #asahi-dev
05:31Chainfire has quit [Remote host closed the connection]
06:34Mary has quit [Quit: The Lounge - https://thelounge.chat]
06:34Mary has joined #asahi-dev
07:48llanhmod has joined #asahi-dev
08:53the_lanetly_052__ has joined #asahi-dev
08:53stefan has joined #asahi-dev
08:59the_lanetly_052___ has quit [Ping timeout: 480 seconds]
09:00stefan has quit []
09:25jannaumacos 13 u-boot fixes pushed to https://github.com/jannau/u-boot-1/tree/macos13-nvme - tested on t600x (macos 13) and t8103 (macos 12.3)
09:26jannaunow the smc crash
09:29nepeat has quit [Ping timeout: 480 seconds]
09:31linuxgemini956 has quit [Ping timeout: 480 seconds]
09:32nepeat has joined #asahi-dev
09:32linuxgemini956 has joined #asahi-dev
09:52jannausmc crashes with the macos 13 firmware because the linux driver acks the ioreport buffer request
09:54jannauor not, I just traced macos
09:57llanhmod has quit [Quit: leaving]
09:58jannaubut yes, that's the issue
09:58jannauone line patch for smc_rtkit.c
10:09jannauI think fixup strategy for users with broken installs should be:
10:09jannau1. provide fixed u-boot and kernel packages
10:10jannau2. prepare a m1n1 + u-boot bundle with smc and simple-framebuffer backlight disabled
10:12jannau3. tell users to replace ESP:m1n1/boot.bin with the bundle from from 2.
10:17jannau4. update the system
10:31svenouch, that‘s a pretty subtle bug
10:37jannaumacos 12.3 acks the crashlog buffer request so there might be future incompabilities
10:52j`eydoesnt that mean a 12.3 macos would crash too?
10:55jannauassuming apple would enforce a consistent usage on all endpoint. this problem was with the ioreport endpoint
11:56derzahl has quit [Remote host closed the connection]
12:28wCPO62 has quit []
12:31wCPO62 has joined #asahi-dev
12:31wCPO62 has quit []
12:32wCPO62 has joined #asahi-dev
12:35kov has joined #asahi-dev
12:35wCPO62 has quit []
12:36wCPO62 has joined #asahi-dev
12:37bakk[m] has joined #asahi-dev
12:43opticron has quit [Ping timeout: 480 seconds]
12:44kettenisno smc means no wifi
12:49kettenisso I think an updated kernel is needed first
12:49kettenisthen you don't need to disable smc in the device tree
12:52kettenisah, you're talking about fixing a broken install
12:52jannauthe kernel is on ext3 so updating the kernel is inconvenient without working Linux
12:53kettenisis it possible to prevent the smc driver from loading?
12:54jannauyes, fixed kernel and u-boot packages should be provided at the same time with unmodified DTBs
12:54jannauyes, but a little bit less convenient. its init function can be blocked on the kernel command line
12:55jannaui.e. the users would have to edit the grub entry
12:56opticron has joined #asahi-dev
13:00kettenisthat is fairly straightforward, but I'll leave it up to you folks to decide what the most fool-proof way is ;)
13:22kettenisjannau: are you planning to do the cleanup and submit the u-boot diff upstream?
13:29jannaukettenis: yes, although I'm a little bit unsure what you mean with cleanup. just the code style indentation, variables defined at the beginning?
13:30kettenisyeah, I have the feeling the _t typedefs will cause some issue for example
13:31kettenisand I don't know what the policy is about embedding code with a different license into a file is
13:32jannauah, I did a quich search and I found similar typedef in other files
13:32kettenisthen it is probably fine
13:33kettenisdo we know what endpoint 10 is about?
13:33jannaudo you see a problem with the direct instantation of sart via of* instead of using the device model?
13:34kettenisI don't, but others might
13:35kettenisone issue is that rtkit.c probably should call the sart functions directly
13:36kettenisso maybe apple_rtkit_init() should accept function pointers to map/unmap and an opaque pointer for those callbacks
13:36jannauyou mean init/free? I guess that's kind of ok as long as rtkit is only used for nvme
13:36kettenistrue, but rtkit.o is included even if you disable nvme
13:37jannauah, I understand
13:37kettenis(that would be somewhat silly but the Kconfig stuff is supposed to express the dependencies properly)
13:38kettenisendpoint 10 isn't handled by the linux kernel rtkit code is it?
13:40jannauno, linux ignores it. m1n1/proxy has "0xa: ASCDummyEndpoint, # tracekit"
13:44kettenisshould add a #define for it
13:44kettenisanyway, if you have a version that you're happy with I can add some comments on github
13:45svenI’m happy to relicense the SART code if it makes life easier fwiw
13:51___nick___ has joined #asahi-dev
13:52___nick___ has quit []
13:53___nick___ has joined #asahi-dev
16:03marcansame, not sure if anyone other than us touched rtkit?
16:03marcanif git blame says it's just folks from around here I'm sure relicensing won't be an issue
16:05jannauit's sart and only touched by sven but I've already moved it to its own file
16:05marcanah, if it's just sart then sven, yeah
16:06marcanjannau: also while you're at it can you bump all the timeouts across the board to at least 100ms, if not 1s?
16:06marcanhaving them at 10ms serves no useful purpose and is just a dumb way for it to break in the future
16:06svenI actually checked before I wrote that comment :D
16:21Guest1499 is now known as Skirmisher[m]
16:41kettenis1s may be a bit excessive since there may be several timeouts and it may take rather long for things to fail
16:41kettenisbut 100ms should be fine
16:49___nick___ has quit []
16:50marcankettenis: I think any one of those failing would bail anyway? but sure, if some codepaths could have that 100ms is fine
16:51___nick___ has joined #asahi-dev
16:51___nick___ has quit []
16:52the_lanetly_052___ has joined #asahi-dev
16:53___nick___ has joined #asahi-dev
16:58the_lanetly_052__ has quit [Ping timeout: 480 seconds]
17:08kettenisactually you're right; each timeout is fatal, so waiting 1s should be ok
18:27amarioguysven: quick question, we need to pass platform_get_irq a pointer to a pdev struct, but the pasemi i2c files only show an platform driver struct, do we just pass that or an element of that into the platform_get_irq func?
18:28svenuh, you should have a pointer to that struct in the apple
18:28svenprobe function
18:34the_lanetly_052___ has quit [Ping timeout: 480 seconds]
19:05confusomu has quit [Remote host closed the connection]
20:08___nick___ has quit [Ping timeout: 480 seconds]
20:21jannauI noticed that nvme_apple.c was missing from MAINTAINERS
20:28ketteniscool, a see a few (very minor) things, so I'll add those
20:28jannauthe commit could maybe splitted into multiple commits
20:29kettenisas comments
20:32kettenisand nice that you did the timeout increase as a separate diff
20:33kettenisburying that in the big diff is defenitely worse
21:10jannauboth comments fixed, I reformulated the comment a little bit
21:10jannauI'll send them tomorrow
21:12kettenislooks good
21:40derzahl has joined #asahi-dev
23:51Illya has joined #asahi-dev
…