2022-03-11
00:15al3xtjames has quit [Quit: Ping timeout (120 seconds)]
00:15chadmedpovik: in reference to your comment, you can define one set of woofers as SNDRV_CHMAP_SL and SNDRV_CHMAP_SL in macaudio.c to differentiate them from the "rear" ones, which id probably use just for the (sub)woofers
00:15al3xtjames has joined #asahi-dev
00:17chadmedit doesnt really matter at the end of the day since each driver is still accessible individually if you know its address, but since they really do different jobs as members of the array they should probably be called different things
00:44yuyichao_ has quit [Ping timeout: 480 seconds]
01:34yuyichao_ has joined #asahi-dev
02:04riker77_ has joined #asahi-dev
02:09riker77 has quit [Ping timeout: 480 seconds]
02:09riker77_ is now known as riker77
02:41minkuu[m] has joined #asahi-dev
03:23phiologe has joined #asahi-dev
03:27PhilippvK has quit [Ping timeout: 480 seconds]
03:33kov has quit [Quit: Coyote finally caught me]
03:33kov has joined #asahi-dev
05:56gladiac has joined #asahi-dev
06:38jannaumarcan: kettenis didn't want u-boot to become the canonical dtb provider https://github.com/AsahiLinux/m1n1/pull/123
07:14the_lanetly_052 has joined #asahi-dev
07:22ChaosPrincess has quit [Ping timeout: 480 seconds]
07:46marcanhonestly though we should have a separate dtbs package with all the magic autopulling from asahi etc
07:48GlanzmannWhy not take the dtb from the kernel? Or is it to much hassle for building m1n1/u-boot?
07:52_jannau_creating a separate git repo from the splitted device tree repo is not a problem. I'll check how fast the filtering of the asahi kernel branch is
07:55_jannau_on distro level it might make sense to install the dtbs from the kernel build and use them when creating the the m1n1+dtb+u-boot binary
07:57MajorBiscuit has joined #asahi-dev
08:00Major_Biscuit has joined #asahi-dev
08:07MajorBiscuit has quit [Ping timeout: 480 seconds]
08:11marcan_jannau_: see https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/
08:11marcanwe should be able to fork that, tweak the scripts a bit and merge in the asahi changes in the same way robher does it
08:12marcanI looked at it in the past but I could've sworn someone else here already gave it a shot at some point?
08:20marcanI wonder why that repo is so large though, is there a ref that points back to the full kernel history? there's no way there's 2GB of just DTS changes...
08:25marcanand I think there was a snafu at some point in that repo and the whole kernel history got pulled into a merge parent...
08:27joske has joined #asahi-dev
08:28kenzie35 has quit []
08:29kenzie35 has joined #asahi-dev
08:31kenzie35 has quit []
08:33marcan_jannau_: try git clone --single-branch -b v5.9-rc2-dts https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/
08:33kenzie35 has joined #asahi-dev
08:33kenzie35 has quit []
08:36kenzie35 has joined #asahi-dev
08:38marcanrobher: btw, since I just stumbled upon https://lore.kernel.org/all/CAL_JsqLuZkL6XztT_Wid3R_ohU01zQwU5HywqpN7hAS4fUNa=g@mail.gmail.com/
08:39marcanhttps://support.github.com/request/fork will give you a silly chatbot auto-form-filler which will file the ticket for you
08:45johey has quit [Ping timeout: 480 seconds]
08:46ChaosPrincess has joined #asahi-dev
08:46marcanlooks like Ian doesn't push the state branches though, so fixing this requires re-doing the entire kernel history...
08:48the_lanetly_052 has quit [Ping timeout: 480 seconds]
08:52johey has joined #asahi-dev
08:53zorun has joined #asahi-dev
08:55mpsI'm thinking adding trigger script which will concatenate dtbs when kernel is installed and/or upgraded
08:56johey has quit []
08:56marcanyou don't *necessarily* always want the kernel/dt to be in sync, but it might be an okay idea for the time being
08:58hizon has quit [Read error: Connection reset by peer]
09:01johey has joined #asahi-dev
09:35chengsun has joined #asahi-dev
09:42chengsun_ has quit [Ping timeout: 480 seconds]
10:13ketteniswe can always reconsider of course, but U-Boot policy is to take device trees from the Linux kernel as much as possible
10:58johey has quit [Quit: ZNC 1.8.2 - https://znc.in]
10:59johey has joined #asahi-dev
11:06chadmedmarcan, povik: i spent most of today doing a bunch of testing, and i seriously do not think we should be applying whatever transformations macos does to the audio. these speakers actually sound significantly better with far less processing, mostly just a crossover and linear coefficient on the tweeters to tame them back a bit
11:07chadmedhttps://gist.github.com/chadmed/2c772c8fdac8280cb17846388203a213#file-experimental-testing <- ive done a writeup on how i came to these conclusions, including values and an asound.conf to reproduce what i did. of course the final product should be done via FIRs/IIRs rather than forcing it through asound, but it demonstrates what im talking about
11:08chadmedthe only transformation absolutely neccessary through that method though is taming down 400-600 Hz on the main set of woofers a bit, but the rest can actually be feasibly done via plain old ALSA through UCM
11:09chadmedpovik: well in my opinion, basically as soon as we get the left woofers to stop dropping out randomly if we go with my method
11:11chadmedpart of any good science experiment is being able to reproduce it perfectly, so of course i need to add the list of music i used heh
11:12chadmedits far from the weirdest thing ive had to include in a paper, i once had to write a real one about peoples biological reaction to counter-strike match replays
11:18povikwell i won't go through it in detail right now, but thanks for sharing what looks like a great write-up!
11:19chadmedno problem, the main thing is just that whatever macos does actually sucks and we should think about something else when the time comes
11:33marcanchadmed: the FIR/IIR would still be done through asound, there's no other good place to put it AFAICT
11:34marcanchadmed: either way we still want to characterize what macos does, if only for comparison purposes within linux, and to see about that stereo magic they do which is a different story
11:35marcanFWIW I also have a calibration mic lying around, so we can plot the real speaker response if we want
11:36marcanthe simple approach is we ship some asound profiles and you just pick the right device :)
11:40marcanbecause the first characters are katakana and spell "moonlight", and the last 2 are kanji (chinese characters) a mean "legend"
11:41chadmedmarcan: my testing was just by listening, but i can pull out my calibration mic tomorrow and do some log sweeps or something if you want. ive just brought the "subs" down to 20 Hz and by themselves with a bit of EQ magic they actually sound really really good so ive definitely got more work to do regardless
11:42chadmedonly thing im worried about is pipewire exploding constantly, but that happens even without my asound so that seems like a driver thing
11:42marcanj`ey: hiragana and katakana are like lowercase and uppercase, two versions of a vaguely phonetic alphabet, but the usage is more like normal text and italics
11:42marcankanji is a totally different thing that encodes actual meaning in each character so... yeah, a lot denser
11:44chadmedive deferred my japanese minor for two years because i dont quite fancy trying to memorise all the kyouiku kanji in one semester lmao
11:44kettenisbut I guess coming up with an agreed upon representation of the filters will be a challenge
11:44marcanchadmed: btw, did you up the pulseaudio resampling quality? IIRC it's... pretty garbage by default
11:45marcankettenis: nah, the linux audio world has given up on that, that's why we have ALSA UCM and all that stuff
11:46marcanI'm not aware of any push to fully describe the audio chain in the DT and I'm not going to block us on that :p
11:46chadmedmarcan: i left it on the default because it was working okayish for what i was doing, but the crackling starts becoming very apparent once i start messing around in carla so thats another job for tomorrow's to do list
11:47marcanpipewire is good but the automagic resampling scares me a bit, JACK is a lot dumber (and thus more predictable)
11:48marcan"good enough for listening", woudln't be doing quality tests through it if I can help it though :-)
11:49marcando we know how macOS caps, is it in the gain setting at the amps or does it just send quieter sample streams and consider that headroom for the filters/etc?
11:50marcanthis is another Unsolved Linux Problem (sigh), I blew up my Chromebook speakers by clicking the wrong thing in alsamixer...
11:50marcanbut at least even if we can clip the drivers a bit, we should limit the max gain kernel-side to something that won't immediately blow them up
11:51marcanbtw, I'm leaning towards not shipping audio (beyond jack-only and mac mini speaker maybe?) for the first release, if only because I want to make sure we nail the safety bit
11:51chadmedyeah it would suck if people blew up their speakers, and i guarantee no ones going to read my little "hey dont turn the volume up" comment in asound
11:52marcanyeah, I've been saying these machines are unbrickable, and I've abused GPIOs enough to be quite confident we'll be fine there
11:54marcanand yeah, honestly, the specific kernel driver should hide all the nonsense, the ASoC idea of exposing everything by default is batshit insane and *completely* unsuitable for desktop systems like these
11:58povikthe speaker amp drivers have an option to enable the I/V sense stuff, but i don't see any way the signals are picked up by anything
12:02arndmarcan: is it intentional that you have not sent any dt changes for 5.18 my way? I see one small patch for the pmu that went into linux-next through the arm64 tree, but nothing else.
12:03povikalso, continuing on what marcan said, the option to enable I/V sense circuitry is exposed... as a knob to userspace :D
12:05kettenislimiting the gain is probably the best we can do without embarking onto an interesting research project ;)
12:05marcanarnd: it is, we haven't really upstreamed anything worth adding this time and t6000 isn't ready yet. I guess it vaguely is as of today, but without the DART changes USB/PCIe don't work so... still rather useless with no way to do networking
12:05marcanbeen focusing on tying up a bunch of jellybean drivers for a public alpha release, then I can kick the kernel upstreaming train again :)
12:05johey has quit [Quit: ZNC 1.8.2 - https://znc.in]
12:06johey has joined #asahi-dev
12:06marcanalso t6002 might make me redo how we organize the t600x device trees, so that's another reason not to rush that one
12:06kettenispersonally I would have liked to see the ans2/nvme bindings and dt changes upstreamed even if there are still some loose ends in the Linux driver
12:07svenI guess I could even send a first nvme RFC. this atcphy has just been more fun than sending patches
12:10svenyeah. maybe some discussions about the compatibles or something but those can happen in the ML anyway
12:11marcanyeah, just put the bindings patch first so if that gets ACKed I can push it via our tree or something
12:11matthewayers[m]Something else I find interesting is how no networks appear under the network config menu in Debian.. is this because of wpa_supplicant.conf doing something fun or is there a disconnect somewhere in the driver when it discovers networks?
12:11arndmarcan: ok, sounds good. just making sure we aren't missing the merge window by accident. Sounds like 5.19 will be bigger then.
12:13arndnot sure how much time I'll be able to spare on t6002 bringup myself, I might wait for you to get it all running first and use a VM guest until then.
12:14marcanthe bringup will be a day of work and then a couple months of bikeshedding over whether to use macros or patch dtc for the devicetrees ;)
12:14svenyou people aren’t helping what little control I still have left that prevents me from buying that thing :P
12:15matthewayers[m]marcan: would you consider the networks not appearing under a desktop env to be release blocking too, since the majority of end-users don’t even know how that works?
12:16marcanmatthewayers[m]: the desktop env I ship will have networks appear, at least they appear for me on KDE :)
12:16arndsven: feel free to come visit me in Dettenhause when I have mine and you want to try stuff out
12:19marcanmatthewayers[m]: FWIW the first release criteria is "core image boots and runs on everything with the expected hardware working at the kernel level and iwd for wifi; plasma image boots and runs on everything and the KDE/preinstalled frontends for stuff that is supposed to work work as expected"
12:20matthewayers[m]marcan: Debian 11 with GNOME. I believe they appeared under KDE when I ran it yesterday afternoon.
12:20marcanother desktops/userspace stacks/network stacks/etc are out of scope at this point, i.e. I want people to report these bugs as part of this first release
12:20matthewayers[m]marcan: Good thing I like KDE :)
12:21marcanobviously there will be bugs, and some bugs will even have nothing to do with us (e.g. wpa_supplicant doesn't work for WPA3 because it doesn't support what brcmfmac uses; clearly not our problem at *this* stage, though something we might want to submit a patch for at some point)
12:21marcanbut also by having people running this, hopefully some subset will be devs willing to track down these problems and fire out patches themselves and save us work :)
12:22j`eymatthewayers[m]: are you sure wifi came up? a few people have had issues with it coming up, so it miht be that rather than a GNOME/DE issue
12:23matthewayers[m]I was able to ping 1.1.1.1 with 0% packet loss
12:23matthewayers[m]… in KDE
12:23matthewayers[m]I’ll do more testing today once I finish my last assignment for the week
12:26matthewayers[m]Gotcha. I’ll de-stress with the soothing Mac startup chime and see what the frequency of that is on my build. I’m using asahi-next
12:27marcanactually going to get into kernel-wrangling mode now, so hopefully I'll fix some of these things
12:50mpsmarcan: you are not only one who fried speakers on chromebook, also I did about 2-3 years ago
12:53mpsmy just starting to 'crackle' when playing anything, and speech can't be understand by anyone
12:55marcanthankfully I was working for Google at the time, so after I shouted angrily at an internal mailing list someone was nice enough to send me replacement speakers for free
12:57amarioguy has joined #asahi-dev
13:00mpsgood keyboard, good anti glare screen, good battery life and fast enough for daily work, only not so for compiling
13:17marcanah, just realized what was wrong with the Mini. nothing, it's just that the firstboot systemd stuff runs before any modules load so it wasn't loading the USB keyboard support...
13:27ChaosPrincess has quit [Remote host closed the connection]
13:29amarioguy has quit [Ping timeout: 480 seconds]
13:53darkapex has joined #asahi-dev
14:00amarioguy has joined #asahi-dev
14:38yuyichao_ has quit [Ping timeout: 480 seconds]
14:41joske has quit [Remote host closed the connection]
14:46nico_32 has quit [Remote host closed the connection]
14:48nico_32 has joined #asahi-dev
14:56ChaosPrincess has joined #asahi-dev
14:56yuyichao_ has joined #asahi-dev
15:12bisko has quit [Read error: Connection reset by peer]
15:23marcanmaz: rebased asahi on top of yesterday's linux-next + irqchip-next, everything seems in order on t6000
15:23marcanthough I noticed I explicitly have to specify firestorm/icestorm to `perf stat`, otherwise by default it only shows the icestorm counters which confused me
15:53amarioguy has quit [Ping timeout: 480 seconds]
15:56amarioguy has joined #asahi-dev
15:59Major_Biscuit has quit []
16:12jannaumaz: one of the imac configs doesn't used pcie port 2. I deleted the port in the model specific dts file. That causes mismatched MSI interrupts. It's trivial to fix in the dts
16:13jannaufixing it in the dts is probably the right thing, the port doesn't vanishes just because it's unused
16:31mazjannau: I'm not sure I get what you changed exactly. we should be able to handle having less ports being described, but it could be that there is a driver bug using the number of ports
16:37yuyichao_ has quit [Quit: Konversation terminated!]
16:38yuyichao has joined #asahi-dev
16:39henje[m] has joined #asahi-dev
16:48jannaumaz: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/apple/t8103-j457.dts#n39 causes constant MSI interrupts for the ethernet card on port02
16:52svenugh.. looks like adding the usb phy node and connecting it to dwc3 but disabling the atcphy driver results in dwc3 not being probed :(
17:34jannauyes, we should not do anything with it as the port is missing from apple's devicetree as well
17:40amarioguy has quit [Ping timeout: 480 seconds]
17:44roxfan has quit [Remote host closed the connection]
17:44kettenishmm, because of some rebasing and force pushes on my side marcan's u-boot merge request has some conflicts
17:47roxfan has joined #asahi-dev
17:48marcanyou could also use git-rebase --onto, but for one or a couple commits cherry-pick is easier
17:52amarioguy has joined #asahi-dev
17:59marcankind of annoying because I'm on linux-next so I have a good 10k commits of junk on top of the devicetree-rebasing repo...
18:02marcanpovik: btw, re what Glanzmann mentioned, see the nvme driver for an example of how to handle multiple power domains properly
18:03marcannot sure if it'll be (much) faster on subsequent runs if I keep the state branch or not (I am resetting the upstream branches but doing a merge-a-fu on the filter state)
18:52PaterTemporalis has joined #asahi-dev
19:46amarioguy has quit [Ping timeout: 480 seconds]
20:01PaterTemporalis has quit [Remote host closed the connection]
20:03PaterTemporalis has joined #asahi-dev
20:06gladiac has quit [Quit: k thx bye]
21:10ChaosPrincess has quit [Remote host closed the connection]
21:49darkapex1 has joined #asahi-dev
21:50darkapex has quit [Ping timeout: 480 seconds]
21:57jannaualso the uint one is only used for a single property with a value of 0. the int one is used with properties which should be unsigned
22:06ChaosPrincess has joined #asahi-dev
22:42int80 has joined #asahi-dev
22:51ChaosPrincess has quit [Remote host closed the connection]
23:11svenugh… brought to you by hours of debugging: 1) when the usb2 phy is powered down the dwc3 soft reset never completes and ofc dwc3 only calls phy_power_on *after* that soft reset ofc
23:11svenand 2) if a phy is connected to a port and that phy is also connected to dwc3 dwc3 won’t probe anymore (silently ofc) because it assumes an extcon connected to the phy must exist :-(
23:12svenand that’s just for the usb2 part. I bet usb3 doesn’t work yet due to another dumb problem like that
23:39yuyichao has quit [Ping timeout: 480 seconds]