#
…

2021-11-22

00:20gladiac is now known as Guest6477
00:20gladiac has joined #asahi-dev
00:26Guest6477 has quit [Ping timeout: 480 seconds]
00:32jannauthe problem seems to be that probing of pinctrl_ap gets deferred because pmgr is not ready
00:33jannauthis seems to cause dart to be initialized before pcie0 and that seems to cause the SErrors
00:36jannauI can work around that by removing the power-domains from pinctrl_ap and pcie0
02:52kenzie has quit [Quit: The Lounge - https://thelounge.chat]
02:54kenzie has joined #asahi-dev
03:07kenzie has quit [Quit: The Lounge - https://thelounge.chat]
03:08kenzie has joined #asahi-dev
03:08kenzie has quit []
03:10kenzie has joined #asahi-dev
03:16phiologe has joined #asahi-dev
03:19PhilippvK has quit [Ping timeout: 480 seconds]
03:21kov has quit [Quit: Coyote finally caught me]
03:46kenzie has quit [Read error: Connection reset by peer]
03:46kenzie has joined #asahi-dev
03:59kenzie has quit [Quit: The Lounge - https://thelounge.chat]
04:21kenzie has joined #asahi-dev
04:32kenzie4 has joined #asahi-dev
04:32kenzie has quit [Ping timeout: 480 seconds]
04:38kenzie41 has joined #asahi-dev
04:39kenzie4 has quit [Read error: Connection reset by peer]
05:38utf8 has joined #asahi-dev
06:29utf8 has quit []
06:34marcanjannau: that looks like an initialization order problem unrelated to pmgr
06:34marcanso the DARTs need apcie to init first? that's... annoying
06:35marcanI'm not seeing that though? I just disabled apcie and the DARTs initialized fine
06:42marcanbut indeed they SError from m1n1 without doing anything, so there's something. but what...
06:43marcanwait no, they don't, I'm stupid
06:43marcanso as long as you call pcie_init() from m1n1 it does work
06:43marcanwhich it should before booting the kernel
06:45marcanlet me update to 12.0.1 and see if something changed...
06:54marcanI'm guessing m1n1's PCIe init needs to do some extra stuff
07:00sventhe thunderbolt darts are going to be annoying like that. they need some TB init before you can access them without serrors :/
07:01marcansven: pcie ones too anyway
07:01marcanbut the weird thing is port0 initialized for jannau
07:01marcanbut not port1
07:01marcannow I'm wondering if the m1n1 pcie init is failing somehow
07:01marcanjannau: can you look for the log on that part?
07:01marcanalso have you updated m1n1 recently? the old PCIe code was all kinds of broken
07:02sveni still kinda hope we can get away with initializing just enough for TB to at least enable the DARTs inside m1n1 without triggering that weird watchdog i ran into last time i tried
07:02marcanyeah, it might work
07:02marcanotherwise we make ATC-CIO another power domain provider :D
07:02svenbecause otherwise this is going to be mess inside the kernel :/
07:02marcanwell, it's not *that* bad, there are ways
07:02svenoh, ATC will already be a reset provider anyway :P
07:02marcanfor example, we can make the DARTs child nodes of the ATC stuff
07:03marcanthat means they won't be autoprobed
07:03marcanthen ATC can choose to probe them whenever it wants
07:03svensure, it's just going to be a mess one way or another
07:03marcanthat kind of fits with the hardware model
07:03marcanwell, I mean, it's just moving the nodes and like 5 lines of code
07:03marcannot exactly a mess
07:03sveni mean the entire TB stuff :D
07:03marcanoh sure :p
07:06marcanyou know what, I bet I know what happened
07:06marcan } else if (adt_is_compatible(adt, adt_offset, "apcie,t6000")) {
07:06marcan port_reg_cnt = 5;
07:06marcanwhat if that isn't t6k
07:06marcanwhat if that is 12.0.1+
07:06marcanthen the first port will work and all the others will die a horrible death
07:07marcan... now the problem is how do I sanely check for firmware versions in m1n1...
07:08marcanyuuuuuup
07:08marcanthat's it
07:08marcangoddammit
07:09marcanbeta5 had 4, 12.0 RC had 5, not sure when it changed, probably with the RC
07:12marcanI guess the easiest thing to do here is count the number of reg entries, subtract the header, and divide by the number of ports
07:25jannaucurrent m1n1 is chainloaded before booting, on disk m1n1 is old. PCI initialisation for pci-bridge1 fails in the chainloaded m1n1
07:25jannaupcie: Port failed to come up on /arm-io/apcie/pci-bridge1
07:25marcanjannau: m1n1 update pushed, should fix your problem
07:25marcan(dammit apple)
07:30jannauyes, problem fixed
07:30marcanrobher: is there some official punishment we can give apple for changing the ADT binding without changing the compatible? ;)
07:32svenoh, i'd like to punish them for some more creative ideas in their ADT while we're at it
07:34svendid you see the agx iommu node (on which agx depends) that's really just a stub that just calls into the main driver?
07:35kettenismarcan: yes, I tried pointing that out to you during one of the streams ;)
07:40marcankettenis: that the change affected t8103 too?
07:47marcanjannau: lol, 12.0.1 broke my display too
07:51marcanI guess that's a reason to update to 12.1 betas and see if they fix it...
07:52marcanfails with two different capture cards
07:53marcandid they actually break HDMI out in iBoot on the Mini across the board?
07:54marcanwell, this is a release blocker for us; we aren't shipping 11.x because just no, and we can't really ship betas, and 12.0.1 critically breaks the framebuffer on the mac mini...
07:54marcanif 12.1 doesn't fix this I'm going to have to start shouting loudly at apple
08:00marcanat least old installs still work, so when the iBoot2 bundle DCP gets loaded, at least that fixes it
08:00marcanwould've been really bad if it broke systemwide
08:01marcanoh hahaha, I just caught a frame from an older macOS boot and there was no apple logo!
08:01marcanI guess iBoot1 is in charge of putting that up, and since that's broken, iBoot2 comes along and initializes a blank framebuffer...
08:01marcan(once DCP loads inside macOS it redraws the logo though)
08:21kode54just FYI they broke color profiles with 12.1 beta 3
08:22kode54"over 10" reports, "potential fix identified" for a future update
08:22kode54having a color profile enabled turns the screen into rainbow barf
08:29the_lanetly_052___ has joined #asahi-dev
08:53marcanand nope, not fixed in the betas
09:11marcanso the good news is dcp.py works as-is on 12.0.1, and all you need to do to make it bring up the screen is a standard modeset
09:27jannaumarcan: any preference how to handle conflicting dts changes for 5.17?
09:28Chainsaw_ has joined #asahi-dev
09:29jannauI have a few minor fixups for the t6000 devicetree? do you want them as merge request for the branch for later stashing
09:29brinly has quit [Ping timeout: 480 seconds]
09:29philpax has quit [Ping timeout: 480 seconds]
09:29robher_ has joined #asahi-dev
09:30nathanchance has quit [Ping timeout: 480 seconds]
09:30esden has quit [Ping timeout: 480 seconds]
09:30kendfinger has quit [Ping timeout: 480 seconds]
09:30tardyp has quit [Ping timeout: 480 seconds]
09:30arnd_ has quit [Ping timeout: 480 seconds]
09:31cptcobalt has quit [Ping timeout: 480 seconds]
09:31austriancoder has quit [Ping timeout: 480 seconds]
09:31sjg1 has quit [Ping timeout: 480 seconds]
09:31NekomimiScience has quit [Ping timeout: 480 seconds]
09:32Ariadne has quit [Ping timeout: 480 seconds]
09:32nkaretnikov has quit [Ping timeout: 480 seconds]
09:32jkkm has quit [Ping timeout: 480 seconds]
09:32jabashque has quit [Ping timeout: 480 seconds]
09:32Chainsaw has quit [Ping timeout: 480 seconds]
09:32robher has quit [Ping timeout: 480 seconds]
09:32Chainsaw_ is now known as Chainsaw
09:32daniels has quit [Ping timeout: 480 seconds]
09:32tom-w has quit [Ping timeout: 480 seconds]
09:32Ariadne has joined #asahi-dev
09:33weems_ has quit [Ping timeout: 480 seconds]
09:33tom-w has joined #asahi-dev
09:34daniels has joined #asahi-dev
09:34jkkm has joined #asahi-dev
09:35nathanchance has joined #asahi-dev
09:35tardyp has joined #asahi-dev
09:35brinly has joined #asahi-dev
09:36philpax has joined #asahi-dev
09:37marcanjannau: anything that applies to the changes in the t6000 bringup branch, you can just send me a PR to it and I'll squash it in and put you down as c-a-b.
09:38marcanif it applies to mainline you can just send it out as usual, up to you :)
09:39cptcobalt has joined #asahi-dev
09:39arnd_ has joined #asahi-dev
09:39nkaretnikov has joined #asahi-dev
09:39sjg1 has joined #asahi-dev
09:40austriancoder has joined #asahi-dev
09:40weems_ has joined #asahi-dev
09:40jabashque has joined #asahi-dev
09:40NekomimiScience has joined #asahi-dev
09:41esden has joined #asahi-dev
09:41kendfinger has joined #asahi-dev
09:41_jannau_fixes for t6000/bringup-work are just minor dts fixes to fix some dtbs_check reports. not even worth a c-a-b imo
09:59kettenismarcan: yes I tried to point out that t8103 also changed
10:00marcanI think I missed that... please shout louder next time :)
10:00kettenisbut I don't blame you for missing that ;)
10:33kov has joined #asahi-dev
10:45mazmarcan: given the level of quality the DWC driver has, I'd rather not touch it at all. I'll happily review patches that implement the speed selection though.
10:46marcanit's... not the prettiest approach :/
10:46marcanit's kind of crappy that we can't use the config space accessors because stuff isn't initialized yet
10:48marcanOTOH it might be possible to just do this in m1n1 too?
10:49marcanfwiw it seems that patch is required to get 10Gbe working on those Mac Minis; I think that NIC only does Gen2 or better, and without it everything trains at Gen1
10:50mazI really wish all this was done in core code. every single driver is reinventing this logic, because the core doesn't understand the PCIe state machine...
10:50marcanthe PCIE_LINK_WIDTH_SPEED_CONTROL bit is dwc-specific
10:51marcanthe speed selection though, yeah
10:56mazmarcan: it's not too horrible though. can you please send it on the list? there are a number of patches already (I reposted the #PERST stuff), and I can prod Lorenzo to pick them up.
11:05gabuscus has quit [Ping timeout: 480 seconds]
11:10marcanwill do :)
11:18the_lanetly_052___ has quit [Ping timeout: 480 seconds]
11:25gabuscus has joined #asahi-dev
11:34X-Scale has joined #asahi-dev
11:39X-Scale` has quit [Ping timeout: 480 seconds]
11:43gabuscus has quit [Ping timeout: 480 seconds]
11:59gabuscus has joined #asahi-dev
12:07aleasto has joined #asahi-dev
13:32V has quit [Remote host closed the connection]
13:35V has joined #asahi-dev
13:58Dcow_ has quit [Quit: My Mac Mini has gone to sleep. ZZZzzz…]
14:31jbowen has joined #asahi-dev
14:39yuyichao_ has quit [Ping timeout: 480 seconds]
14:47rkt has joined #asahi-dev
14:48rkt has left #asahi-dev [#asahi-dev]
14:49dottedmag has joined #asahi-dev
15:01yuyichao_ has joined #asahi-dev
15:07gladiac is now known as Guest6521
15:07gladiac has joined #asahi-dev
15:09method_ has joined #asahi-dev
15:13Guest6521 has quit [Ping timeout: 480 seconds]
15:14Method has quit [Ping timeout: 480 seconds]
15:44jbowen has quit [Ping timeout: 480 seconds]
15:44yuyichao has joined #asahi-dev
15:47yuyichao_ has quit [Ping timeout: 480 seconds]
15:48yuyichao_ has joined #asahi-dev
15:49gladiac is now known as Guest6527
15:49gladiac has joined #asahi-dev
15:52yuyichao has quit [Ping timeout: 480 seconds]
15:55Guest6527 has quit [Ping timeout: 480 seconds]
16:03jbowen has joined #asahi-dev
17:32jbowen has quit [Ping timeout: 480 seconds]
17:51jbowen has joined #asahi-dev
18:19HardWall has joined #asahi-dev
18:23RealityVoid has quit [Ping timeout: 480 seconds]
19:04jbowen has quit [Ping timeout: 480 seconds]
20:57Dcow has joined #asahi-dev
20:58Dcow has quit []
21:00Dcow has joined #asahi-dev
21:45X-Scale` has joined #asahi-dev
21:49aleasto has quit [Quit: Konversation terminated!]
21:51X-Scale has quit [Ping timeout: 480 seconds]
23:02Dcow has quit [Quit: My Mac Mini has gone to sleep. ZZZzzz…]
23:07Dcow has joined #asahi-dev
23:56yuyichao_ has quit [Ping timeout: 480 seconds]
…